You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/24 14:00:20 UTC

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #8982: [api] fix, set default columns to just id when not defined

dpgaspar commented on a change in pull request #8982: [api] fix, set default columns to just id when not defined
URL: https://github.com/apache/incubator-superset/pull/8982#discussion_r370646758
 
 

 ##########
 File path: superset/views/base_api.py
 ##########
 @@ -82,6 +82,18 @@ class BaseSupersetModelRestApi(ModelRestApi):
         }
     """  # pylint: disable=pointless-string-statement
 
+    def _init_properties(self):
 
 Review comment:
   Everything is possible, on this case would probably involve a somewhat delicate change on FAB. My take is that, this is just a fallback, enough to force everyone to always declare CRUD fields explicitly or else the API will return nothing of value (like just the id's)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org