You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/11 18:27:58 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #20034: chore: Changes the no-literal-colors lint rule to throw errors instead of warnings
michael-s-molina opened a new pull request, #20034:
URL: https://github.com/apache/superset/pull/20034
### SUMMARY
Changes the `no-literal-colors` lint rule to throw errors instead of warnings.
The following PRs removed the hard-coded colors from the codebase allowing this rule to be changed: https://github.com/apache/superset/pull/20006, https://github.com/apache/superset/pull/20016, https://github.com/apache/superset/pull/19923, https://github.com/apache/superset/pull/19493, https://github.com/apache/superset/pull/19466, https://github.com/apache/superset/pull/19443, https://github.com/apache/superset/pull/19439
### TESTING INSTRUCTIONS
Check that there are no literal color lint-related errors.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #20034: chore: Changes the no-literal-colors lint rule to throw errors instead of warnings
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20034:
URL: https://github.com/apache/superset/pull/20034#issuecomment-1125037616
# [Codecov](https://codecov.io/gh/apache/superset/pull/20034?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20034](https://codecov.io/gh/apache/superset/pull/20034?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af93975) into [master](https://codecov.io/gh/apache/superset/commit/c4c714fffb83b2a5236202ee43d837f218685b15?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c4c714f) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head af93975 differs from pull request most recent head 6150cc3. Consider uploading reports for the commit 6150cc3 to get more accurate results
```diff
@@ Coverage Diff @@
## master #20034 +/- ##
=======================================
Coverage 66.35% 66.35%
=======================================
Files 1712 1712
Lines 64083 64083
Branches 6744 6744
=======================================
Hits 42523 42523
Misses 19847 19847
Partials 1713 1713
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.31% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/20034?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/20034?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c4c714f...6150cc3](https://codecov.io/gh/apache/superset/pull/20034?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #20034: chore: Changes the no-literal-colors lint rule to throw errors instead of warnings
Posted by GitBox <gi...@apache.org>.
michael-s-molina merged PR #20034:
URL: https://github.com/apache/superset/pull/20034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org