You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Evelina Dumitrescu <ev...@gmail.com> on 2015/03/03 12:27:35 UTC
Re: Review Request 31473: mesos: Make fromLinkDevice method member of
the IPNetwork class.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31473/
-----------------------------------------------------------
(Updated March 3, 2015, 11:27 a.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Repository: mesos
Description
-------
see summary
Diffs (updated)
-----
src/slave/containerizer/isolators/network/port_mapping.cpp 5227987cdb7b904c2f4bb2bdf5c5d705a435010d
src/tests/port_mapping_tests.cpp e2c8ba12b5574b06a6ba60c3c3a30b63cea1d23c
Diff: https://reviews.apache.org/r/31473/diff/
Testing
-------
Thanks,
Evelina Dumitrescu
Re: Review Request 31473: mesos: Make fromLinkDevice method member of
the IPNetwork class.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31473/#review75552
-----------------------------------------------------------
Bad patch!
Reviews applied: [31473]
Failed command: ./support/apply-review.sh -n -r 31473
Error:
2015-03-06 22:08:32 URL:https://reviews.apache.org/r/31473/diff/raw/ [1489/1489] -> "31473.patch" [1]
error: patch failed: src/slave/containerizer/isolators/network/port_mapping.cpp:1056
error: src/slave/containerizer/isolators/network/port_mapping.cpp: patch does not apply
error: patch failed: src/tests/port_mapping_tests.cpp:193
error: src/tests/port_mapping_tests.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On March 6, 2015, 7:58 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31473/
> -----------------------------------------------------------
>
> (Updated March 6, 2015, 7:58 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 5227987cdb7b904c2f4bb2bdf5c5d705a435010d
> src/tests/port_mapping_tests.cpp e2c8ba12b5574b06a6ba60c3c3a30b63cea1d23c
>
> Diff: https://reviews.apache.org/r/31473/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 31473: mesos: Make fromLinkDevice method member of
the IPNetwork class.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31473/#review75913
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On March 10, 2015, 8:36 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31473/
> -----------------------------------------------------------
>
> (Updated March 10, 2015, 8:36 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 7a38735a2722e634ba913e8d571d0dfbd0ac7468
> src/tests/port_mapping_tests.cpp dd00b6f30139a2d62d873a9d46763f05393a91c7
>
> Diff: https://reviews.apache.org/r/31473/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 31473: mesos: Make fromLinkDevice method member of
the IPNetwork class.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31473/
-----------------------------------------------------------
(Updated March 10, 2015, 8:36 a.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Repository: mesos
Description
-------
see summary
Diffs (updated)
-----
src/slave/containerizer/isolators/network/port_mapping.cpp 7a38735a2722e634ba913e8d571d0dfbd0ac7468
src/tests/port_mapping_tests.cpp dd00b6f30139a2d62d873a9d46763f05393a91c7
Diff: https://reviews.apache.org/r/31473/diff/
Testing
-------
Thanks,
Evelina Dumitrescu
Re: Review Request 31473: mesos: Make fromLinkDevice method member of
the IPNetwork class.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31473/
-----------------------------------------------------------
(Updated March 6, 2015, 7:58 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Repository: mesos
Description
-------
see summary
Diffs
-----
src/slave/containerizer/isolators/network/port_mapping.cpp 5227987cdb7b904c2f4bb2bdf5c5d705a435010d
src/tests/port_mapping_tests.cpp e2c8ba12b5574b06a6ba60c3c3a30b63cea1d23c
Diff: https://reviews.apache.org/r/31473/diff/
Testing
-------
Thanks,
Evelina Dumitrescu
Re: Review Request 31473: mesos: Make fromLinkDevice method member of
the IPNetwork class.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31473/
-----------------------------------------------------------
(Updated March 5, 2015, 3:48 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Repository: mesos
Description
-------
see summary
Diffs (updated)
-----
src/slave/containerizer/isolators/network/port_mapping.cpp 5227987cdb7b904c2f4bb2bdf5c5d705a435010d
src/tests/port_mapping_tests.cpp e2c8ba12b5574b06a6ba60c3c3a30b63cea1d23c
Diff: https://reviews.apache.org/r/31473/diff/
Testing
-------
Thanks,
Evelina Dumitrescu