Re: Difference of behavior between svn 1.4.5 and 1.5.1 for svnlook diff

[Daniel Shahaf <d....@daniel.shahaf.name>]

Daniel Shahaf wrote on Thu, 28 Aug 2008 at 18:04 +0300:
> C. Michael Pilato wrote on Thu, 28 Aug 2008 at 10:13 -0400:
> > Looks like in the original recipe, the copied thing was a directory (copied
> > from "trunk").  Is that significant?
> > 
> 
> Yes.  (Julian pointed out the same.)
> 
> 	% /usr/bin/svnlook diff -r2 r1
> 	Copied: trunk2 (from rev 1, trunk)
> 
> 	% svnlook diff -r2 r1
> 
> 	%
> 

Filed as http://subversion.tigris.org/issues/show_bug.cgi?id=3292.  

Frederic (or Frédéric?), do you have time to provide a patch?

Daniel

> In 1.4, it just prints the "Copied" header immediately:
> 
>       SVN_ERR(svn_cmdline_printf(pool, _("Copied: %s (from rev %ld, %s)\n"),
>                                  path, node->copyfrom_rev, base_path));
>       printed_header = TRUE;
> 
> but in trunk, it uses a buffer:
> 
>       svn_stringbuf_appendcstr
>         (header,
>          apr_psprintf(pool, _("Copied: %s (from rev %ld, %s)\n"),
>                       path, node->copyfrom_rev, base_path));
> 
> And, apparently, never prints its contents for the directory case...
> 
> Daniel