You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by shazron <gi...@git.apache.org> on 2017/03/02 00:13:52 UTC
[GitHub] cordova-ios pull request #293: CB-12523 - Remove iOS 8 support
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/293
CB-12523 - Remove iOS 8 support
### Platforms affected
iOS
### What does this PR do?
Bump up minimum deployment target to iOS 9.
### What testing has been done on this change?
`npm test` and also created a new project with the cordova-ios platform that includes this change, and built for both device and simulator.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-ios CB-12523
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/293.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #293
----
commit afa32be6f04542a2b6f8927c9e43615434458fa5
Author: Shazron Abdullah <sh...@gmail.com>
Date: 2017-03-02T00:12:35Z
CB-12523 - Remove iOS 8 support
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #293: CB-12523 - Remove iOS 8 support
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/293
Travis CI: Looks like the iOS Simulator was never even run, and it failed. Tested it locally again and it works. Flaky CI (esp since it took over 24 hours before this was run on CI)
@jcesarmobile looks like the tests even pass with that 8.0 value in. Which tells me that value was never tested in the first place? (bad test)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #293: CB-12523 - Remove iOS 8 support
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/293
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #293: CB-12523 - Remove iOS 8 support
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-ios/pull/293
A few tests are set to iOS 8 like https://github.com/apache/cordova-ios/blob/master/tests/spec/unit/fixtures/test-config-2.xml#L15
Should them also be updated?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org