[GitHub] [dubbo] djl394922860 commented on a diff in pull request #8954: [3.0] run timeout task in separate thread to avoid the worker thread blocking

[GitBox <gi...@apache.org>]

djl394922860 commented on code in PR #8954:
URL: https://github.com/apache/dubbo/pull/8954#discussion_r923110072


##########
dubbo-common/src/main/java/org/apache/dubbo/common/timer/HashedWheelTimer.java:
##########
@@ -647,6 +679,26 @@ public void expire() {
                 return;
             }
 
+            // run timeout task at separate thread to avoid the worker thread blocking
+            try {
+                if (timer.taskExecutor == null) {
+                    // the global executor service should be gotten at each calling to avoid using invalid executor.
+                    GlobalResourcesRepository.getGlobalExecutorService().execute(this);

Review Comment:
   `taskExecutor` must not null ? Whether to consider that are must required ？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org