You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/06/12 06:30:53 UTC
[GitHub] [incubator-apisix] ShiningRush commented on a change in pull request #1697: [batch-request]feat: cp all header to every request
ShiningRush commented on a change in pull request #1697:
URL: https://github.com/apache/incubator-apisix/pull/1697#discussion_r439231665
##########
File path: t/plugin/batch-requests.t
##########
@@ -716,24 +722,28 @@ passed
{
"status": 200,
"headers": {
- "X-Cookie": "request-cookies-b"
+ "X-Cookie": "request-cookies-b",
+ "X-HeaderB": "request-header-b"
}
},
{
"status": 201,
"headers": {
- "X-Cookie": "request-cookies-c"
+ "X-Cookie": "request-cookies-c",
+ "X-HeaderC": "request-header-c"
}
},
{
"status": 202,
"headers": {
- "X-Cookie": "request-cookies-d"
+ "X-Cookie": "request-cookies-d",
+ "X-HeaderD": "request-header-d"
}
}
]]=],
{
- Cookie = "request-cookies"
+ Cookie = "request-cookies",
+ Header = "request-header"
Review comment:
You mean we should not name key like "Cookie" or "Header"?But browner will send cookie into the http header named "Cookie", it is http specification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org