You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/04/15 20:45:00 UTC
[GitHub] [incubator-iceberg] rdsr opened a new issue #926: Support
notification on table writes
rdsr opened a new issue #926: Support notification on table writes
URL: https://github.com/apache/incubator-iceberg/issues/926
We have notifications when scanning tables. I think we also need notifications when a table is appended to, or updated etc. basically to support notifications on writes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdsr commented on issue #926: Support
notification on table writes
Posted by GitBox <gi...@apache.org>.
rdsr commented on issue #926: Support notification on table writes
URL: https://github.com/apache/incubator-iceberg/issues/926#issuecomment-615545646
One minor issue I see now is that there's no table and db name in the update classes, which would be very helpful to add it to the update event
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdsr commented on issue #926: Support
notification on table writes
Posted by GitBox <gi...@apache.org>.
rdsr commented on issue #926: Support notification on table writes
URL: https://github.com/apache/incubator-iceberg/issues/926#issuecomment-615535665
My idea is update the `PendingUpdate<T>` interface and add a default method there
```
default UpdateEvent updateEvent() {
return UpdateEvent.NoOpEvent.INSTANCE;
}
```
Each update implementation will extend this interface and provide implementation of updateEvent.
`SnapshotProducer` will execute the listener code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdsr edited a comment on issue #926: Support
notification on table writes
Posted by GitBox <gi...@apache.org>.
rdsr edited a comment on issue #926: Support notification on table writes
URL: https://github.com/apache/incubator-iceberg/issues/926#issuecomment-615535665
My idea is to update the `PendingUpdate<T>` interface and add a default method there
```
default UpdateEvent updateEvent() {
return UpdateEvent.NoOpEvent.INSTANCE;
}
```
Each update implementation will extend this interface and provide implementation of `updateEvent()`. `SnapshotProducer` will execute the listener code to call listeners tied to the event, as the last step in the `commit()` method
@rdblue thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdsr edited a comment on issue #926: Support
notification on table writes
Posted by GitBox <gi...@apache.org>.
rdsr edited a comment on issue #926: Support notification on table writes
URL: https://github.com/apache/incubator-iceberg/issues/926#issuecomment-615535665
My idea is to update the `PendingUpdate<T>` interface and add a default method there
```
default UpdateEvent updateEvent() {
return UpdateEvent.NoOpEvent.INSTANCE;
}
```
Each update implementation implementing this interface will provide implementation of `updateEvent()`. `SnapshotProducer` will execute the listener code to call listeners tied to the event, as the last step in the `commit()` method
@rdblue thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdsr edited a comment on issue #926: Support
notification on table writes
Posted by GitBox <gi...@apache.org>.
rdsr edited a comment on issue #926: Support notification on table writes
URL: https://github.com/apache/incubator-iceberg/issues/926#issuecomment-615535665
My idea is to update the `PendingUpdate<T>` interface and add a default method there
```
default UpdateEvent updateEvent() {
return UpdateEvent.NoOpEvent.INSTANCE;
}
```
Each update implementation will extend this interface and provide implementation of `updateEvent()`. `SnapshotProducer` will execute the listener code to call listeners tied to the event.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdsr edited a comment on issue #926: Support
notification on table writes
Posted by GitBox <gi...@apache.org>.
rdsr edited a comment on issue #926: Support notification on table writes
URL: https://github.com/apache/incubator-iceberg/issues/926#issuecomment-615535665
My idea is to update the `PendingUpdate<T>` interface and add a default method there
```
default UpdateEvent updateEvent() {
return UpdateEvent.NoOpEvent.INSTANCE;
}
```
Each update api implementing this interface will provide implementation of `updateEvent()`. `SnapshotProducer` will execute the listener code to call listeners tied to the event, as the last step in the `commit()` method
@rdblue thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdsr edited a comment on issue #926: Support
notification on table writes
Posted by GitBox <gi...@apache.org>.
rdsr edited a comment on issue #926: Support notification on table writes
URL: https://github.com/apache/incubator-iceberg/issues/926#issuecomment-615535665
My idea is to update the `PendingUpdate<T>` interface and add a default method there
```
default UpdateEvent updateEvent() {
return UpdateEvent.NoOpEvent.INSTANCE;
}
```
Each update implementation will extend this interface and provide implementation of updateEvent.
`SnapshotProducer` will execute the listener code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdsr edited a comment on issue #926: Support
notification on table writes
Posted by GitBox <gi...@apache.org>.
rdsr edited a comment on issue #926: Support notification on table writes
URL: https://github.com/apache/incubator-iceberg/issues/926#issuecomment-615535665
My idea is to update the `PendingUpdate<T>` interface and add a default method there
```
default UpdateEvent updateEvent() {
return UpdateEvent.NoOpEvent.INSTANCE;
}
```
Each update implementation will extend this interface and provide implementation of `updateEvent()`. `SnapshotProducer` will execute the listener code to call listeners tied to the event.
@rdblue thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdsr edited a comment on issue #926: Support
notification on table writes
Posted by GitBox <gi...@apache.org>.
rdsr edited a comment on issue #926: Support notification on table writes
URL: https://github.com/apache/incubator-iceberg/issues/926#issuecomment-615545646
One minor issue I see now is that there's no table and db name in the update classes, which would be very helpful to add it to the update event. One option I'm considering is exposing a `tableIdentifier()` from `TableOperations` API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdsr commented on issue #926: Support
notification on table writes
Posted by GitBox <gi...@apache.org>.
rdsr commented on issue #926: Support notification on table writes
URL: https://github.com/apache/incubator-iceberg/issues/926#issuecomment-615567480
`tableIdentifier()` may not make sense for `HadoopTableOperations`, maybe be can provide a `tablePath` api which both Hadoop and MetastoreOperations can implement?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org