You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by "Srikanth Sundarrajan (JIRA)" <ji...@apache.org> on 2014/11/19 03:17:34 UTC

[jira] [Commented] (FALCON-807) Fix order of actual and expected expression in assert statements.

    [ https://issues.apache.org/jira/browse/FALCON-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217284#comment-14217284 ] 

Srikanth Sundarrajan commented on FALCON-807:
---------------------------------------------

I see changes only to Integration tests, does it mean that assertions elsewhere are fine ?

> Fix order of actual and expected expression in assert statements.
> -----------------------------------------------------------------
>
>                 Key: FALCON-807
>                 URL: https://issues.apache.org/jira/browse/FALCON-807
>             Project: Falcon
>          Issue Type: Improvement
>            Reporter: Ajay Yadav
>            Assignee: Ajay Yadav
>         Attachments: FALCON-807.patch
>
>
> In Assert statements like assertEquals, actual expression should be first and expected expression should be second argument. In certain files e.g. FalconCLIIT.java we have it other way round. 
> Impact of this is:
> When the test fails the error message will say something like:
> Expected -1 but was 0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)