You are viewing a plain text version of this content. The canonical link for it is here.
Posted to wagon-dev@maven.apache.org by Emmanuel Venisse <em...@venisse.net> on 2003/12/11 14:55:06 UTC

DefaultWagonManager

Hi Michal,

I see that you use a list in DefaultWagonManager for store factories, and
you loop on it for search the appropriate factory.
I think it's better if you use a hashtable or hashmap for store factories,
the search will be better.

Emmanuel


---------------------------------------------------------------------
To unsubscribe, e-mail: wagon-dev-unsubscribe@maven.apache.org
For additional commands, e-mail: wagon-dev-help@maven.apache.org


Re: DefaultWagonManager

Posted by Emmanuel Venisse <em...@venisse.net>.
You didn't delete factories list. Why?
It's never use out of addFactory method.

Emmanuel

----- Original Message ----- 
From: "Michal Maczka" <mm...@interia.pl>
To: <wa...@maven.apache.org>
Sent: Thursday, December 11, 2003 10:22 PM
Subject: RE: DefaultWagonManager


>
>
> > -----Original Message-----
> > From: Emmanuel Venisse [mailto:emmanuel@venisse.net]
> > Sent: Thursday, December 11, 2003 2:55 PM
> > To: wagon-dev@maven.apache.org
> > Subject: DefaultWagonManager
> >
> >
> > Hi Michal,
> >
> > I see that you use a list in DefaultWagonManager for store factories,
and
> > you loop on it for search the appropriate factory.
> > I think it's better if you use a hashtable or hashmap for store
factories,
> > the search will be better.
> >
> > Emmanuel
> >
>
> Fixed. Thx for a hint!
>
> I wanted to support "deregistration" of WagonProviders. I think it won't
be
> needed and even if it still can be supported
> when bith Map and List ADT are used (like I am doing now).
>
>
> Michal
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: wagon-dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: wagon-dev-help@maven.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: wagon-dev-unsubscribe@maven.apache.org
For additional commands, e-mail: wagon-dev-help@maven.apache.org


RE: DefaultWagonManager

Posted by Michal Maczka <mm...@interia.pl>.

> -----Original Message-----
> From: Emmanuel Venisse [mailto:emmanuel@venisse.net]
> Sent: Thursday, December 11, 2003 2:55 PM
> To: wagon-dev@maven.apache.org
> Subject: DefaultWagonManager
>
>
> Hi Michal,
>
> I see that you use a list in DefaultWagonManager for store factories, and
> you loop on it for search the appropriate factory.
> I think it's better if you use a hashtable or hashmap for store factories,
> the search will be better.
>
> Emmanuel
>

Fixed. Thx for a hint!

I wanted to support "deregistration" of WagonProviders. I think it won't be
needed and even if it still can be supported
when bith Map and List ADT are used (like I am doing now).


Michal



---------------------------------------------------------------------
To unsubscribe, e-mail: wagon-dev-unsubscribe@maven.apache.org
For additional commands, e-mail: wagon-dev-help@maven.apache.org