You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "vibhatha (via GitHub)" <gi...@apache.org> on 2024/01/19 02:00:02 UTC
[PR] MINOR: [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 in /java/maven V2 [arrow]
vibhatha opened a new pull request, #39694:
URL: https://github.com/apache/arrow/pull/39694
### Rationale for this change
This PR was created in place of https://github.com/apache/arrow/pull/39202 to integrate the `puppycrawl.tools.checkstyle` upgrade.
### What changes are included in this PR?
Style changes in Java classes and core changes to the style format itself.
Some unsupported attributes have been removed. And some attributes have
been reorganized upon the provided guidelines in the documentation.
### Are these changes tested?
N/A
Tested by existing checkstyle guideline.
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on code in PR #39694:
URL: https://github.com/apache/arrow/pull/39694#discussion_r1465051277
##########
java/dev/checkstyle/checkstyle.xml:
##########
@@ -223,14 +224,8 @@
<module name="JavadocMethod">
<property name="scope" value="public"/>
<property name="allowMissingParamTags" value="true"/>
- <property name="allowMissingThrowsTags" value="true"/>
<property name="allowMissingReturnTag" value="true"/>
- <property name="minLineCount" value="2"/>
<property name="allowedAnnotations" value="Override, Test"/>
- <property name="allowThrowsTagsForSubclasses" value="true"/>
- <!-- This seems partially broken under JDK >= 9. -->
- <property name="suppressLoadErrors" value="true"/>
- <property name="ignoreMethodNamesRegex" value="main"/>
Review Comment:
It showed up errors when running with those configs. I didn't log them, but I can reproduce the errors and post here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #39694:
URL: https://github.com/apache/arrow/pull/39694#discussion_r1465164626
##########
java/dev/checkstyle/checkstyle.xml:
##########
@@ -223,14 +224,8 @@
<module name="JavadocMethod">
<property name="scope" value="public"/>
<property name="allowMissingParamTags" value="true"/>
- <property name="allowMissingThrowsTags" value="true"/>
<property name="allowMissingReturnTag" value="true"/>
- <property name="minLineCount" value="2"/>
<property name="allowedAnnotations" value="Override, Test"/>
- <property name="allowThrowsTagsForSubclasses" value="true"/>
- <!-- This seems partially broken under JDK >= 9. -->
- <property name="suppressLoadErrors" value="true"/>
- <property name="ignoreMethodNamesRegex" value="main"/>
Review Comment:
Yes, let's just take a look and make sure - I don't care too much either way but perhaps some of these will still be useful even after google-java-format (since many of these seem more like lint things)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #39694:
URL: https://github.com/apache/arrow/pull/39694#discussion_r1461962768
##########
java/dev/checkstyle/checkstyle.xml:
##########
@@ -223,14 +224,14 @@
<module name="JavadocMethod">
<property name="scope" value="public"/>
<property name="allowMissingParamTags" value="true"/>
- <property name="allowMissingThrowsTags" value="true"/>
+<!-- <property name="allowMissingThrowsTags" value="true"/>-->
Review Comment:
Is this ready or not ready? Please keep PRs in draft until they are ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on PR #39694:
URL: https://github.com/apache/arrow/pull/39694#issuecomment-1905642123
@lidavidm the file noted in the error seems to be generated https://github.com/ursacomputing/crossbow/actions/runs/7622553317/job/20760815369#step:7:35295
Should we omit such generated resources from checkstyles?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 in /java/maven V2 [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on PR #39694:
URL: https://github.com/apache/arrow/pull/39694#issuecomment-1899596330
Not sure if there is such a line though:
https://github.com/ursacomputing/crossbow/actions/runs/7578473688/job/20641129446#step:7:35880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 in /java/maven V2 [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on PR #39694:
URL: https://github.com/apache/arrow/pull/39694#issuecomment-1899594150
@github-actions crossbow submit *java*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on PR #39694:
URL: https://github.com/apache/arrow/pull/39694#issuecomment-1903916434
@github-actions crossbow submit *java*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 in /java/maven V2 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39694:
URL: https://github.com/apache/arrow/pull/39694#issuecomment-1899523290
Revision: 671b530eceb7b629d979b09306faa9637fa0127e
Submitted crossbow builds: [ursacomputing/crossbow @ actions-dd3d152807](https://github.com/ursacomputing/crossbow/branches/all?query=actions-dd3d152807)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/7578473831/job/20641130638)|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7578473832/job/20641129850)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7578473791/job/20641129635)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7578473836/job/20641129871)|
|verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7578473800/job/20641129678)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7578473688/job/20641129446)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39946: [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #39694:
URL: https://github.com/apache/arrow/pull/39694#issuecomment-1928187951
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit cb5c109a5d6985264203e256ddae0b210251e820.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/21247489864) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on code in PR #39694:
URL: https://github.com/apache/arrow/pull/39694#discussion_r1478303027
##########
java/dev/checkstyle/checkstyle.xml:
##########
@@ -223,14 +224,8 @@
<module name="JavadocMethod">
<property name="scope" value="public"/>
<property name="allowMissingParamTags" value="true"/>
- <property name="allowMissingThrowsTags" value="true"/>
<property name="allowMissingReturnTag" value="true"/>
- <property name="minLineCount" value="2"/>
<property name="allowedAnnotations" value="Override, Test"/>
- <property name="allowThrowsTagsForSubclasses" value="true"/>
- <!-- This seems partially broken under JDK >= 9. -->
- <property name="suppressLoadErrors" value="true"/>
- <property name="ignoreMethodNamesRegex" value="main"/>
Review Comment:
@lidavidm I added the `MissingJavadocMethodCheck`
Latest version: https://checkstyle.sourceforge.io/version/8.29/config_javadoc.html#JavadocMethod
Previois version: https://checkstyle.sourceforge.io/version/8.19/config_javadoc.html#JavadocMethod
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on PR #39694:
URL: https://github.com/apache/arrow/pull/39694#issuecomment-1927085609
@github-actions crossbow submit *java*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on code in PR #39694:
URL: https://github.com/apache/arrow/pull/39694#discussion_r1478303027
##########
java/dev/checkstyle/checkstyle.xml:
##########
@@ -223,14 +224,8 @@
<module name="JavadocMethod">
<property name="scope" value="public"/>
<property name="allowMissingParamTags" value="true"/>
- <property name="allowMissingThrowsTags" value="true"/>
<property name="allowMissingReturnTag" value="true"/>
- <property name="minLineCount" value="2"/>
<property name="allowedAnnotations" value="Override, Test"/>
- <property name="allowThrowsTagsForSubclasses" value="true"/>
- <!-- This seems partially broken under JDK >= 9. -->
- <property name="suppressLoadErrors" value="true"/>
- <property name="ignoreMethodNamesRegex" value="main"/>
Review Comment:
@lidavidm I added the `MissingJavadocMethodCheck`
Latest version: https://checkstyle.sourceforge.io/version/8.29/config_javadoc.html#JavadocMethod
Previous version: https://checkstyle.sourceforge.io/version/8.19/config_javadoc.html#JavadocMethod
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on PR #39694:
URL: https://github.com/apache/arrow/pull/39694#issuecomment-1907302453
@github-actions crossbow submit *java*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on code in PR #39694:
URL: https://github.com/apache/arrow/pull/39694#discussion_r1465166444
##########
java/dev/checkstyle/checkstyle.xml:
##########
@@ -223,14 +224,8 @@
<module name="JavadocMethod">
<property name="scope" value="public"/>
<property name="allowMissingParamTags" value="true"/>
- <property name="allowMissingThrowsTags" value="true"/>
<property name="allowMissingReturnTag" value="true"/>
- <property name="minLineCount" value="2"/>
<property name="allowedAnnotations" value="Override, Test"/>
- <property name="allowThrowsTagsForSubclasses" value="true"/>
- <!-- This seems partially broken under JDK >= 9. -->
- <property name="suppressLoadErrors" value="true"/>
- <property name="ignoreMethodNamesRegex" value="main"/>
Review Comment:
Yes I agree, let me log one by one here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on code in PR #39694:
URL: https://github.com/apache/arrow/pull/39694#discussion_r1475866391
##########
java/dev/checkstyle/checkstyle.xml:
##########
@@ -223,14 +224,8 @@
<module name="JavadocMethod">
<property name="scope" value="public"/>
<property name="allowMissingParamTags" value="true"/>
- <property name="allowMissingThrowsTags" value="true"/>
<property name="allowMissingReturnTag" value="true"/>
- <property name="minLineCount" value="2"/>
<property name="allowedAnnotations" value="Override, Test"/>
- <property name="allowThrowsTagsForSubclasses" value="true"/>
- <!-- This seems partially broken under JDK >= 9. -->
- <property name="suppressLoadErrors" value="true"/>
- <property name="ignoreMethodNamesRegex" value="main"/>
Review Comment:
@lidavidm these are the errors I saw when each of these properties were used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 in /java/maven V2 [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on PR #39694:
URL: https://github.com/apache/arrow/pull/39694#issuecomment-1899520927
@github-actions crossbow submit *java*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39694:
URL: https://github.com/apache/arrow/pull/39694#issuecomment-1903921062
Revision: e07b4453c3d2639f453c46b50c4664b132f7b977
Submitted crossbow builds: [ursacomputing/crossbow @ actions-5f3cb7c61a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-5f3cb7c61a)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/7611236103/job/20726285249)|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7611236075/job/20726283211)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7611236088/job/20726283190)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7611236067/job/20726283199)|
|verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7611236063/job/20726283178)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7611236066/job/20726283435)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on code in PR #39694:
URL: https://github.com/apache/arrow/pull/39694#discussion_r1475865870
##########
java/dev/checkstyle/checkstyle.xml:
##########
@@ -223,14 +224,8 @@
<module name="JavadocMethod">
<property name="scope" value="public"/>
<property name="allowMissingParamTags" value="true"/>
- <property name="allowMissingThrowsTags" value="true"/>
<property name="allowMissingReturnTag" value="true"/>
- <property name="minLineCount" value="2"/>
<property name="allowedAnnotations" value="Override, Test"/>
- <property name="allowThrowsTagsForSubclasses" value="true"/>
- <!-- This seems partially broken under JDK >= 9. -->
- <property name="suppressLoadErrors" value="true"/>
- <property name="ignoreMethodNamesRegex" value="main"/>
Review Comment:
Listing compile errors for the removed attributes
1. `<property name="allowMissingThrowsTags" value="true"/>`
```bash
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on project arrow-maven-plugins: Failed during checkstyle configuration: cannot initialize module TreeWalker - cannot initialize module JavadocMethod - Property 'allowMissingThrowsTags' does not exist, please check the documentation -> [Help 1]
```
2. `<property name="minLineCount" value="2"/>`
```bash
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on project arrow-maven-plugins: Failed during checkstyle configuration: cannot initialize module TreeWalker - cannot initialize module JavadocMethod - Property 'minLineCount' does not exist, please check the documentation -> [Help 1]
```
3. `<property name="allowThrowsTagsForSubclasses" value="true"/>`
```bash
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on project arrow-maven-plugins: Failed during checkstyle configuration: cannot initialize module TreeWalker - cannot initialize module JavadocMethod - Property 'allowThrowsTagsForSubclasses' does not exist, please check the documentation -> [Help 1]
```
4. `<property name="suppressLoadErrors" value="true"/>`
```bash
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on project arrow-maven-plugins: Failed during checkstyle configuration: cannot initialize module TreeWalker - cannot initialize module JavadocMethod - Property 'suppressLoadErrors' does not exist, please check the documentation -> [Help 1]
```
5. `<property name="ignoreMethodNamesRegex" value="main"/>`
```bash
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on project arrow-maven-plugins: Failed during checkstyle configuration: cannot initialize module TreeWalker - cannot initialize module JavadocMethod - Property 'ignoreMethodNamesRegex' does not exist, please check the documentation -> [Help 1]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #39694:
URL: https://github.com/apache/arrow/pull/39694#discussion_r1476192713
##########
java/dev/checkstyle/checkstyle.xml:
##########
@@ -223,14 +224,8 @@
<module name="JavadocMethod">
<property name="scope" value="public"/>
<property name="allowMissingParamTags" value="true"/>
- <property name="allowMissingThrowsTags" value="true"/>
<property name="allowMissingReturnTag" value="true"/>
- <property name="minLineCount" value="2"/>
<property name="allowedAnnotations" value="Override, Test"/>
- <property name="allowThrowsTagsForSubclasses" value="true"/>
- <!-- This seems partially broken under JDK >= 9. -->
- <property name="suppressLoadErrors" value="true"/>
- <property name="ignoreMethodNamesRegex" value="main"/>
Review Comment:
`https://github.com/checkstyle/checkstyle/issues/7329`
- allowMissingThrowsTags, allowThrowsTagsForSubclasses, suppressLoadErrors are now basically the default
`https://github.com/checkstyle/checkstyle/issues/6703`
- minLineCount and ignoreMethodNamesRegex were moved to a new check called `MissingJavadocMethodCheck`, can you configure that to behave like our old one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on code in PR #39694:
URL: https://github.com/apache/arrow/pull/39694#discussion_r1476856913
##########
java/dev/checkstyle/checkstyle.xml:
##########
@@ -223,14 +224,8 @@
<module name="JavadocMethod">
<property name="scope" value="public"/>
<property name="allowMissingParamTags" value="true"/>
- <property name="allowMissingThrowsTags" value="true"/>
<property name="allowMissingReturnTag" value="true"/>
- <property name="minLineCount" value="2"/>
<property name="allowedAnnotations" value="Override, Test"/>
- <property name="allowThrowsTagsForSubclasses" value="true"/>
- <!-- This seems partially broken under JDK >= 9. -->
- <property name="suppressLoadErrors" value="true"/>
- <property name="ignoreMethodNamesRegex" value="main"/>
Review Comment:
Ah I see. Let me check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 in /java/maven V2 [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on code in PR #39694:
URL: https://github.com/apache/arrow/pull/39694#discussion_r1458191726
##########
java/dev/checkstyle/checkstyle.xml:
##########
@@ -223,14 +224,14 @@
<module name="JavadocMethod">
<property name="scope" value="public"/>
<property name="allowMissingParamTags" value="true"/>
- <property name="allowMissingThrowsTags" value="true"/>
+<!-- <property name="allowMissingThrowsTags" value="true"/>-->
Review Comment:
will remove these once CIs are verified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 in /java/maven V2 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39694:
URL: https://github.com/apache/arrow/pull/39694#issuecomment-1899599130
Revision: 671b530eceb7b629d979b09306faa9637fa0127e
Submitted crossbow builds: [ursacomputing/crossbow @ actions-7d4c086df1](https://github.com/ursacomputing/crossbow/branches/all?query=actions-7d4c086df1)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/7578964829/job/20642421741)|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7578964752/job/20642420339)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7578964791/job/20642420766)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7578964732/job/20642420356)|
|verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7578964665/job/20642420320)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7578964673/job/20642420325)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39694:
URL: https://github.com/apache/arrow/pull/39694#issuecomment-1907303951
Revision: 0ded73270cd10c40f3bba158e9d7bb3fe342f9ee
Submitted crossbow builds: [ursacomputing/crossbow @ actions-3c29e853de](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3c29e853de)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/7635225325/job/20800294113)|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7635225338/job/20800293738)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7635225363/job/20800293864)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7635225351/job/20800293838)|
|verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7635225401/job/20800293959)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7635225324/job/20800293744)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on PR #39694:
URL: https://github.com/apache/arrow/pull/39694#issuecomment-1907460369
@lidavidm seems like the CIs are passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #39694:
URL: https://github.com/apache/arrow/pull/39694#discussion_r1465022731
##########
java/dev/checkstyle/checkstyle.xml:
##########
@@ -223,14 +224,8 @@
<module name="JavadocMethod">
<property name="scope" value="public"/>
<property name="allowMissingParamTags" value="true"/>
- <property name="allowMissingThrowsTags" value="true"/>
<property name="allowMissingReturnTag" value="true"/>
- <property name="minLineCount" value="2"/>
<property name="allowedAnnotations" value="Override, Test"/>
- <property name="allowThrowsTagsForSubclasses" value="true"/>
- <!-- This seems partially broken under JDK >= 9. -->
- <property name="suppressLoadErrors" value="true"/>
- <property name="ignoreMethodNamesRegex" value="main"/>
Review Comment:
Are these checks no longer supported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on code in PR #39694:
URL: https://github.com/apache/arrow/pull/39694#discussion_r1478307482
##########
java/dev/checkstyle/checkstyle.xml:
##########
@@ -223,14 +224,8 @@
<module name="JavadocMethod">
<property name="scope" value="public"/>
<property name="allowMissingParamTags" value="true"/>
- <property name="allowMissingThrowsTags" value="true"/>
<property name="allowMissingReturnTag" value="true"/>
- <property name="minLineCount" value="2"/>
<property name="allowedAnnotations" value="Override, Test"/>
- <property name="allowThrowsTagsForSubclasses" value="true"/>
- <!-- This seems partially broken under JDK >= 9. -->
- <property name="suppressLoadErrors" value="true"/>
- <property name="ignoreMethodNamesRegex" value="main"/>
Review Comment:
> allowMissingThrowsTags, allowThrowsTagsForSubclasses, suppressLoadErrors are now basically the default
These are not explicity properties in `8.29` but were in `8.19` but I couldn't find whether they are the defaults in `8.29`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39946: [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #39694:
URL: https://github.com/apache/arrow/pull/39694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39694:
URL: https://github.com/apache/arrow/pull/39694#issuecomment-1927090402
Revision: ca838fb9d9b548e2a15b01867e875ffdd410cb56
Submitted crossbow builds: [ursacomputing/crossbow @ actions-d6ad59a58d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d6ad59a58d)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/7785709890/job/21228923254)|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7785709893/job/21228919502)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7785709896/job/21228919422)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7785709886/job/21228919491)|
|verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7785709880/job/21228919644)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7785709885/job/21228919395)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on code in PR #39694:
URL: https://github.com/apache/arrow/pull/39694#discussion_r1478307482
##########
java/dev/checkstyle/checkstyle.xml:
##########
@@ -223,14 +224,8 @@
<module name="JavadocMethod">
<property name="scope" value="public"/>
<property name="allowMissingParamTags" value="true"/>
- <property name="allowMissingThrowsTags" value="true"/>
<property name="allowMissingReturnTag" value="true"/>
- <property name="minLineCount" value="2"/>
<property name="allowedAnnotations" value="Override, Test"/>
- <property name="allowThrowsTagsForSubclasses" value="true"/>
- <!-- This seems partially broken under JDK >= 9. -->
- <property name="suppressLoadErrors" value="true"/>
- <property name="ignoreMethodNamesRegex" value="main"/>
Review Comment:
> allowMissingThrowsTags, allowThrowsTagsForSubclasses, suppressLoadErrors are now basically the default
These are not explicit properties in `8.29` but were in `8.19` but I couldn't find whether they are the defaults in `8.29`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39946: [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39694:
URL: https://github.com/apache/arrow/pull/39694#issuecomment-1927461892
:warning: GitHub issue #39946 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on code in PR #39694:
URL: https://github.com/apache/arrow/pull/39694#discussion_r1461973046
##########
java/dev/checkstyle/checkstyle.xml:
##########
@@ -223,14 +224,14 @@
<module name="JavadocMethod">
<property name="scope" value="public"/>
<property name="allowMissingParamTags" value="true"/>
- <property name="allowMissingThrowsTags" value="true"/>
+<!-- <property name="allowMissingThrowsTags" value="true"/>-->
Review Comment:
This should have been on draft. Sorry about the mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39694:
URL: https://github.com/apache/arrow/pull/39694#issuecomment-1905467454
Revision: 3a74b4dcd16894b2599e830e114590665bb43a94
Submitted crossbow builds: [ursacomputing/crossbow @ actions-4f8459f26a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-4f8459f26a)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/7622553153/job/20760815772)|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7622553231/job/20760814991)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7622553335/job/20760815350)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7622553218/job/20760814883)|
|verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7622553205/job/20760814854)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7622553317/job/20760815369)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on PR #39694:
URL: https://github.com/apache/arrow/pull/39694#issuecomment-1905464498
@github-actions crossbow submit *java*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #39694:
URL: https://github.com/apache/arrow/pull/39694#issuecomment-1906198658
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org