[GitHub] [airflow] uranusjr commented on a diff in pull request #34026: AIP-44 Migrate Job to Internal API

["uranusjr (via GitHub)" <gi...@apache.org>]

uranusjr commented on code in PR #34026:
URL: https://github.com/apache/airflow/pull/34026#discussion_r1315449185


##########
airflow/jobs/base_job_runner.py:
##########
@@ -27,7 +27,7 @@
     from airflow.jobs.job import Job
     from airflow.serialization.pydantic.job import JobPydantic
 
-J = TypeVar("J", "Job", "JobPydantic", "Job | JobPydantic")
+J = TypeVar("J", "Job", "Job")

Review Comment:
   This type variable (and the runner being a generic) is not needed if you don’t need multiple classes.



##########
airflow/jobs/base_job_runner.py:
##########
@@ -27,7 +27,7 @@
     from airflow.jobs.job import Job
     from airflow.serialization.pydantic.job import JobPydantic
 
-J = TypeVar("J", "Job", "JobPydantic", "Job | JobPydantic")
+J = TypeVar("J", "Job", "Job")

Review Comment:
   This type variable (and the runner being a generic) is not needed if you don’t need multiple classes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org