[jira] [Commented] (HTTPCLIENT-2106) Credentials charset for DigestScheme can not be configured any more

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202805#comment-17202805 ] 

ASF subversion and git services commented on HTTPCLIENT-2106:
-------------------------------------------------------------

Commit 1c55aa1548f04af9d84bfd4df023e6ecd63f3378 in httpcomponents-client's branch refs/heads/master from Oleg Kalnichevski
[ https://gitbox.apache.org/repos/asf?p=httpcomponents-client.git;h=1c55aa1 ]

HTTPCLIENT-2106: Added charset parameter for DigestScheme


> Credentials charset for DigestScheme can not be configured any more
> -------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-2106
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2106
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient (classic)
>    Affects Versions: 5.0.1
>            Reporter: synth3
>            Priority: Minor
>             Fix For: 5.1
>
>
> I am currently migrating from hc 4.x to hc 5.0.1 and faced a Problem:
> In hc 4.x I was able to set the credentials charset to use for digest auth by creating a "DigestSchemeFactory" using this constructor: [DigestSchemeFactory(java.nio.charset.Charset)|https://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/impl/auth/DigestSchemeFactory.html#DigestSchemeFactory(java.nio.charset.Charset)] and adding the instance to a "AuthSchemeRegistry" which I set as default for the client instance to use.
>  
> This is no longer possible (the encoding for "DigestScheme" can not be changed anymore), but probably needed when e.g. a password contains characters outside of "ISO-8859-1" (the current internal default for DigestScheme).
>  
> A possible (unattractive) workaround would be copying a lot of code (implement a own "DigestSchemeFactory", overwrite "org.apache.hc.client5.http.impl.auth.DigestScheme.generateAuthResponse(HttpHost, HttpRequest, HttpContext)", copy/modify "org.apache.hc.client5.http.impl.auth.DigestScheme.createDigestResponse(HttpRequest)" and copy "org.apache.hc.client5.http.impl.auth.HttpEntityDigester").
>  
> Also: Is there a Place where I find information that helps me to understand the decisions made for hc 5?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org