You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by tsingfu <gi...@git.apache.org> on 2015/04/14 05:21:12 UTC

[GitHub] spark pull request: [SPARK-5466] Add explicit guava dependencies w...

Github user tsingfu commented on the pull request:

    https://github.com/apache/spark/pull/4272#issuecomment-92579447
  
    @vanzin , today I found *sql/hive-thriftserver* also needs explicit guava dependencies. But in `sql/hive-thriftserver/pom.xml` the scope of  `com.google.guava.guava` is `runtime`, and this causes build error as same as in [SPARK-5466](https://issues.apache.org/jira/browse/SPARK-5466).
    
    my test: 
    I try the scope with `compile`, build works fine.
    vi sql/hive-thriftserver/pom.xml
    ```
        <dependency>
          <groupId>com.google.guava</groupId>
          <artifactId>guava</artifactId>
          <!-- <scope>runtime</scope> -->
        </dependency>
    ```
    
    cc @pwendell 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org