You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2025/07/18 10:58:16 UTC

[PR] SLING-12861 Switch to bundle version 1.0.0-SNAPSHOT [sling-org-apache-sling-distribution-api]

kwin opened a new pull request, #15:
URL: https://github.com/apache/sling-org-apache-sling-distribution-api/pull/15

   Upgrade all package versions to 1.0.0
   Enable baselining


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] SLING-12861 Switch to bundle version 1.0.0-SNAPSHOT [sling-org-apache-sling-distribution-api]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #15:
URL: https://github.com/apache/sling-org-apache-sling-distribution-api/pull/15#issuecomment-3089081470

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-distribution-api&pullRequest=15) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api&pullRequest=15&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api&pullRequest=15&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-api&pullRequest=15&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-api&pullRequest=15&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-api&pullRequest=15&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-distribution-api&pullRequest=15)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] SLING-12861 Switch to bundle version 1.0.0-SNAPSHOT [sling-org-apache-sling-distribution-api]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #15:
URL: https://github.com/apache/sling-org-apache-sling-distribution-api/pull/15#issuecomment-3160811584

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-distribution-api&pullRequest=15) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api&pullRequest=15&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api&pullRequest=15&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-api&pullRequest=15&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-api&pullRequest=15&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-api&pullRequest=15&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-distribution-api&pullRequest=15)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] SLING-12861 Switch to bundle version 1.0.0-SNAPSHOT [sling-org-apache-sling-distribution-api]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #15:
URL: https://github.com/apache/sling-org-apache-sling-distribution-api/pull/15#issuecomment-3089549713

   > What is the purpose of increasing version on the packages?
   
   I was somehow assuming that package versions < 1.0 are treated specially. But maybe I am wrong. Seems this indeed breaks consumers as I see current import ranges being calculated like
   
   `Import-Package: org.apache.sling.distribution; version="[0.4, 1)"` (e.g. in https://github.com/Adobe-Consulting-Services/acs-aem-commons/tree/master/bundle-cloud). Probably the special case was just for bundle version (https://bnd.bndtools.org/chapters/180-baselining.html)
   
   > the baselining is started with one exception: the bundle version must be more than 1.0.0. If the version is less no baselining is possible, the purpose is to allow the primordial baseline to be established without errors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] SLING-12861 Switch to bundle version 1.0.0-SNAPSHOT [sling-org-apache-sling-distribution-api]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #15:
URL: https://github.com/apache/sling-org-apache-sling-distribution-api/pull/15#issuecomment-3113876832

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-distribution-api&pullRequest=15) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api&pullRequest=15&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api&pullRequest=15&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-api&pullRequest=15&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-api&pullRequest=15&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-api&pullRequest=15&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-distribution-api&pullRequest=15)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] SLING-12861 Switch to bundle version 1.0.0-SNAPSHOT [sling-org-apache-sling-distribution-api]

Posted by "cschneider (via GitHub)" <gi...@apache.org>.
cschneider commented on PR #15:
URL: https://github.com/apache/sling-org-apache-sling-distribution-api/pull/15#issuecomment-3095941764

   @tmaret Do you think updating the API to 1.0.0 is safe?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] SLING-12861 Switch to bundle version 1.0.0-SNAPSHOT [sling-org-apache-sling-distribution-api]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #15:
URL: https://github.com/apache/sling-org-apache-sling-distribution-api/pull/15#discussion_r2217895994


##########
pom.xml:
##########
@@ -59,6 +59,10 @@
                 <groupId>biz.aQute.bnd</groupId>
                 <artifactId>bnd-maven-plugin</artifactId>
             </plugin>
+            <plugin>

Review Comment:
   Actually all relevant bnd plugins are already activated through bundle-parent (https://github.com/apache/sling-parent/blob/4d051750e93d473d9918c8498233cd42f0f991e6/sling-bundle-parent/pom.xml#L164).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] SLING-12861 Switch to bundle version 1.0.0-SNAPSHOT [sling-org-apache-sling-distribution-api]

Posted by "cschneider (via GitHub)" <gi...@apache.org>.
cschneider commented on code in PR #15:
URL: https://github.com/apache/sling-org-apache-sling-distribution-api/pull/15#discussion_r2218667830


##########
pom.xml:
##########
@@ -59,6 +59,10 @@
                 <groupId>biz.aQute.bnd</groupId>
                 <artifactId>bnd-maven-plugin</artifactId>
             </plugin>
+            <plugin>

Review Comment:
   Can you remove the plugin?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] SLING-12861 Switch to bundle version 1.0.0-SNAPSHOT [sling-org-apache-sling-distribution-api]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #15:
URL: https://github.com/apache/sling-org-apache-sling-distribution-api/pull/15#issuecomment-3094580623

   There is some logic related to 0.x versions in https://github.com/bndtools/bnd/blob/28ee79bf1ee0a68d12c599cceafca679ac1c7958/biz.aQute.bndlib/src/aQute/bnd/differ/Baseline.java#L326.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] SLING-12861 Switch to bundle version 1.0.0-SNAPSHOT [sling-org-apache-sling-distribution-api]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #15:
URL: https://github.com/apache/sling-org-apache-sling-distribution-api/pull/15#issuecomment-3113870610

   > @tmaret Do you think updating the API to 1.0.0 is safe?
   
   Compare with the discussion at https://lists.apache.org/thread/xtdr34srcl9d9oszfozw4phn0g715ghn


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] SLING-12861 Switch to bundle version 1.0.0-SNAPSHOT [sling-org-apache-sling-distribution-api]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #15:
URL: https://github.com/apache/sling-org-apache-sling-distribution-api/pull/15#discussion_r2228824735


##########
pom.xml:
##########
@@ -59,6 +59,10 @@
                 <groupId>biz.aQute.bnd</groupId>
                 <artifactId>bnd-maven-plugin</artifactId>
             </plugin>
+            <plugin>

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] SLING-12861 Switch to bundle version 1.0.0-SNAPSHOT [sling-org-apache-sling-distribution-api]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin merged PR #15:
URL: https://github.com/apache/sling-org-apache-sling-distribution-api/pull/15


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] SLING-12861 Switch to bundle version 1.0.0-SNAPSHOT [sling-org-apache-sling-distribution-api]

Posted by "cschneider (via GitHub)" <gi...@apache.org>.
cschneider commented on PR #15:
URL: https://github.com/apache/sling-org-apache-sling-distribution-api/pull/15#issuecomment-3089189332

   What is the purpose of increasing version on the packages?
   This will require all users of the API to upgrade.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org