[GitHub] [incubator-nuttx] btashton edited a comment on issue #757: Create release artifacts for release branches

[GitBox <gi...@apache.org>]

btashton edited a comment on issue #757:
URL: https://github.com/apache/incubator-nuttx/pull/757#issuecomment-616970850


   > The version string is just used here:
   > 
   > ```
   > VER_TAG=`git describe --abbrev=0 --match "nuttx-$NUTTX_VERSION" --match "nuttx-$NUTTX_VERSION-*" --match "nuttx-$NUTTX_VERSION.[0-9]*"  2>/dev/null`
   > ```
   > 
   > I think the below variant should also work too:
   > 
   > ```
   > VER_TAG=`git describe --abbrev=0 --match "nuttx-*"  2>/dev/null`
   > ```
   
   The additional matches are intentional. I watch to match
   ```
   nuttx-0.1
   nuttx-0.1.1 nuttx-0.1.2 nuttx-0.1.3
   nuttx-0.1.1-RC1
   ```
   I do _not_ want to match `nuttx-some-fix`  and more importantly at some point we will tag
   9.1 and may still backport and only want to match 9.0.# not 9.1.#
   
   > 
   > If not, we still can pass BRANCH_VER=${GITHUB_REF##*/} to zipme.sh and then version.sh.
   > It doesn't make sense that we have two scripts(version.sh and gitver.sh) generate the similar thing, because:
   > 1.It confuse user which script he/she should use
   > 2.Developer may forget to update both script at the same time
   > If version.sh doesn't work well with release process, it's better to enhance it to handle the new usage correctly instead creating a new similar script.
   
   `version.sh` is expecting to be passed a full version string  `gitversion.sh` can provide this value to it in the context of a CI run.  It really does not make sense outside of a CI run, but it is complicated enough I did not want to shove it in the yaml file.
   
   ```
   $ version.sh -v `gitversion.sh 0.1`
   ```
   
   `version.sh` job is really just setting the config files.  The fact that it tries to guess a version number from git is out of its job in my opinion.  Why not drop version being optional and just:
   ```
   version.sh -v `git describe --match nuttx-[0-9].* --abbrev=0`
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org