[GitHub] [arrow] jhorstmann commented on a change in pull request #8609: ARROW-10513: [Rust]: ARMv7 compilation

[GitBox <gi...@apache.org>]

jhorstmann commented on a change in pull request #8609:
URL: https://github.com/apache/arrow/pull/8609#discussion_r523458622



##########
File path: rust/arrow/src/memory.rs
##########
@@ -22,6 +22,14 @@ use std::alloc::Layout;
 use std::mem::align_of;
 use std::ptr::NonNull;
 
+/// Target pointer width of the targeted platform
+#[cfg(target_pointer_width = "64")]
+pub(crate) const POINTER_WIDTH: usize = 64;

Review comment:
       If this is in bits, how is it related to the alignment check below? It also makes the usage in the size calculations a little confusing since that needs to convert to bytes.
   
   Just an idea, could this be defined without the `cfg` attributes, something like `std::mem::size_of::<*const u8>()`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org