The wrong way to close PRs

[David Blevins <da...@gmail.com>]

When creating the tomee-release-tools git repo I mistakenly did a force push to the wrong repo, the main tomee repo.  This closed most of the open PRs.

Steps taken so far:

 - Worked with Apache Infra on slack to restore the repo.  This still doesn't allow the PRs to be re-opened, unfortunately.
 - Working with Richard who has an affected PR to see if there is a way to reopen his PR others might use.

If you have any thoughts or suggestions on ways to reopen the existing PRs, that's very welcome and encouraged.


-David

Re: The wrong way to close PRs

[Jean-Louis Monteiro <jl...@tomitribe.com>]

All fixed now!
We can get back to fixing the master after TCK work
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Tue, May 11, 2021 at 7:49 PM Zowalla, Richard <
richard.zowalla@hs-heilbronn.de> wrote:

> We re-created some (newer) PRs, which were not older than January 2021,
> linked the related JIRA as well as the original PR to preserve
> discussions.
>
> Sadly, it was not possible to get GitHub to refresh a closed PR (even
> though the source branch was updated and a "new" PR works).
>
> I guess, we can leave the older ones "closed". If applicable or needed,
> we (or the author) can re-create them? wdyt?
>
> Gruss
> Richard
>
>
> Am Dienstag, den 11.05.2021, 10:33 -0700 schrieb David Blevins:
> > > On May 11, 2021, at 10:18 AM, Jean-Louis Monteiro <
> > > jlmonteiro@tomitribe.com> wrote:
> > >
> > > If people used a branch, you can re-create the PR like this
> >
> > Note Apache doesn't allow attachments, so the image didn't come
> > through.
> >
> > > Click on the branch link. Then create the pull request. I'll do
> > > this one as an example.
> > > https://github.com/apache/tomee/pull/791
> > >
> > > What other PR do you have to restore?
> >
> > Here's the full list of PRs I inadvertently closed:
> >
> > https://github.com/apache/tomee/pull/110
> > https://github.com/apache/tomee/pull/789
> > https://github.com/apache/tomee/pull/340
> > https://github.com/apache/tomee/pull/316
> > https://github.com/apache/tomee/pull/467
> > https://github.com/apache/tomee/pull/360
> > https://github.com/apache/tomee/pull/65
> > https://github.com/apache/tomee/pull/670
> > https://github.com/apache/tomee/pull/677
> > https://github.com/apache/tomee/pull/664
> > https://github.com/apache/tomee/pull/268
> > https://github.com/apache/tomee/pull/721
> > https://github.com/apache/tomee/pull/321
> > https://github.com/apache/tomee/pull/180
> > https://github.com/apache/tomee/pull/678
> > https://github.com/apache/tomee/pull/634
> > https://github.com/apache/tomee/pull/633
> > https://github.com/apache/tomee/pull/716
> >
> >
> > -David
> >
> > > --
> > > Jean-Louis Monteiro
> > > http://twitter.com/jlouismonteiro
> > > http://www.tomitribe.com
> > >
> > >
> > > On Tue, May 11, 2021 at 6:38 PM David Blevins <
> > > david.blevins@gmail.com> wrote:
> > > When creating the tomee-release-tools git repo I mistakenly did a
> > > force push to the wrong repo, the main tomee repo.  This closed
> > > most of the open PRs.
> > >
> > > Steps taken so far:
> > >
> > >  - Worked with Apache Infra on slack to restore the repo.  This
> > > still doesn't allow the PRs to be re-opened, unfortunately.
> > >  - Working with Richard who has an affected PR to see if there is a
> > > way to reopen his PR others might use.
> > >
> > > If you have any thoughts or suggestions on ways to reopen the
> > > existing PRs, that's very welcome and encouraged.
> > >
> > >
> > > -David
> > >
>

Re: The wrong way to close PRs

["Zowalla, Richard" <ri...@hs-heilbronn.de>]

We re-created some (newer) PRs, which were not older than January 2021,
linked the related JIRA as well as the original PR to preserve
discussions.

Sadly, it was not possible to get GitHub to refresh a closed PR (even
though the source branch was updated and a "new" PR works). 

I guess, we can leave the older ones "closed". If applicable or needed,
we (or the author) can re-create them? wdyt?

Gruss
Richard


Am Dienstag, den 11.05.2021, 10:33 -0700 schrieb David Blevins:
> > On May 11, 2021, at 10:18 AM, Jean-Louis Monteiro <
> > jlmonteiro@tomitribe.com> wrote:
> > 
> > If people used a branch, you can re-create the PR like this 
> 
> Note Apache doesn't allow attachments, so the image didn't come
> through.
> 
> > Click on the branch link. Then create the pull request. I'll do
> > this one as an example.
> > https://github.com/apache/tomee/pull/791
> > 
> > What other PR do you have to restore?
> 
> Here's the full list of PRs I inadvertently closed:
> 
> https://github.com/apache/tomee/pull/110
> https://github.com/apache/tomee/pull/789
> https://github.com/apache/tomee/pull/340
> https://github.com/apache/tomee/pull/316
> https://github.com/apache/tomee/pull/467
> https://github.com/apache/tomee/pull/360
> https://github.com/apache/tomee/pull/65
> https://github.com/apache/tomee/pull/670
> https://github.com/apache/tomee/pull/677
> https://github.com/apache/tomee/pull/664
> https://github.com/apache/tomee/pull/268
> https://github.com/apache/tomee/pull/721
> https://github.com/apache/tomee/pull/321
> https://github.com/apache/tomee/pull/180
> https://github.com/apache/tomee/pull/678
> https://github.com/apache/tomee/pull/634
> https://github.com/apache/tomee/pull/633
> https://github.com/apache/tomee/pull/716
> 
> 
> -David
> 
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> > 
> > 
> > On Tue, May 11, 2021 at 6:38 PM David Blevins <
> > david.blevins@gmail.com> wrote:
> > When creating the tomee-release-tools git repo I mistakenly did a
> > force push to the wrong repo, the main tomee repo.  This closed
> > most of the open PRs.
> > 
> > Steps taken so far:
> > 
> >  - Worked with Apache Infra on slack to restore the repo.  This
> > still doesn't allow the PRs to be re-opened, unfortunately.
> >  - Working with Richard who has an affected PR to see if there is a
> > way to reopen his PR others might use.
> > 
> > If you have any thoughts or suggestions on ways to reopen the
> > existing PRs, that's very welcome and encouraged.
> > 
> > 
> > -David
> > 

Re: The wrong way to close PRs

[David Blevins <db...@tomitribe.com>]

> On May 11, 2021, at 10:18 AM, Jean-Louis Monteiro <jl...@tomitribe.com> wrote:
> 
> If people used a branch, you can re-create the PR like this 

Note Apache doesn't allow attachments, so the image didn't come through.

> Click on the branch link. Then create the pull request. I'll do this one as an example.
> https://github.com/apache/tomee/pull/791
> 
> What other PR do you have to restore?

Here's the full list of PRs I inadvertently closed:

https://github.com/apache/tomee/pull/110
https://github.com/apache/tomee/pull/789
https://github.com/apache/tomee/pull/340
https://github.com/apache/tomee/pull/316
https://github.com/apache/tomee/pull/467
https://github.com/apache/tomee/pull/360
https://github.com/apache/tomee/pull/65
https://github.com/apache/tomee/pull/670
https://github.com/apache/tomee/pull/677
https://github.com/apache/tomee/pull/664
https://github.com/apache/tomee/pull/268
https://github.com/apache/tomee/pull/721
https://github.com/apache/tomee/pull/321
https://github.com/apache/tomee/pull/180
https://github.com/apache/tomee/pull/678
https://github.com/apache/tomee/pull/634
https://github.com/apache/tomee/pull/633
https://github.com/apache/tomee/pull/716


-David

> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
> 
> 
> On Tue, May 11, 2021 at 6:38 PM David Blevins <da...@gmail.com> wrote:
> When creating the tomee-release-tools git repo I mistakenly did a force push to the wrong repo, the main tomee repo.  This closed most of the open PRs.
> 
> Steps taken so far:
> 
>  - Worked with Apache Infra on slack to restore the repo.  This still doesn't allow the PRs to be re-opened, unfortunately.
>  - Working with Richard who has an affected PR to see if there is a way to reopen his PR others might use.
> 
> If you have any thoughts or suggestions on ways to reopen the existing PRs, that's very welcome and encouraged.
> 
> 
> -David
> 

Re: The wrong way to close PRs

[Jean-Louis Monteiro <jl...@tomitribe.com>]

If people used a branch, you can re-create the PR like this
[image: image.png]

Click on the branch link. Then create the pull request. I'll do this one as
an example.
https://github.com/apache/tomee/pull/791

What other PR do you have to restore?
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Tue, May 11, 2021 at 6:38 PM David Blevins <da...@gmail.com>
wrote:

> When creating the tomee-release-tools git repo I mistakenly did a force
> push to the wrong repo, the main tomee repo.  This closed most of the open
> PRs.
>
> Steps taken so far:
>
>  - Worked with Apache Infra on slack to restore the repo.  This still
> doesn't allow the PRs to be re-opened, unfortunately.
>  - Working with Richard who has an affected PR to see if there is a way to
> reopen his PR others might use.
>
> If you have any thoughts or suggestions on ways to reopen the existing
> PRs, that's very welcome and encouraged.
>
>
> -David
>
>