You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/13 22:56:01 UTC

[GitHub] [spark] xinrong-databricks opened a new pull request #33982: [SPARK-36748][PYTHON] Introduce the 'compute.isin_limit' option

xinrong-databricks opened a new pull request #33982:
URL: https://github.com/apache/spark/pull/33982


   ### What changes were proposed in this pull request?
   Introduce the 'compute.isin_limit' option, with the default value of 80.
   
   ### Why are the changes needed?
   `Column.isin(list)` doesn't perform well when the given `list` is large, as https://issues.apache.org/jira/browse/SPARK-33383.
   Thus, 'compute.isin_limit' is introduced to constrain the usage of `Column.isin(list)` in the code base.
   If the length of the ‘list’ is above the `'compute.isin_limit'`, broadcast join is used instead for better performance.
   
   #### Why is the default value 80?
   After reproducing the benchmark mentioned in https://issues.apache.org/jira/browse/SPARK-33383, 
   
   | length of filtering list | isin time /ms| broadcast DF time / ms|
   | :---:   | :-: | :-: |
   | 200 | 69411 | 39296 |
   | 100 | 43074 | 40087 |
   | 80 | 35592 | 40350 |
   | 50 | 28134 | 37847 |
   
   We may notice when the length of the filtering list <= 80, the `isin` approach performs better than `broadcast DF`.
   
   ### Does this PR introduce _any_ user-facing change?
   Users may read/write the value of `'compute.isin_limit'` as follows
   ```py
   >>> ps.get_option('compute.isin_limit')
   80
   
   >>> ps.set_option('compute.isin_limit', 10)
   >>> ps.get_option('compute.isin_limit')
   10
   
   >>> ps.set_option('compute.isin_limit', -1)
   ...
   ValueError: 'compute.isin_limit' should be greater than or equal to 0.
   
   >>> ps.reset_option('compute.isin_limit')
   >>> ps.get_option('compute.isin_limit')
   80
   ```
   
   ### How was this patch tested?
   Manual test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33982: [SPARK-36748][PYTHON] Introduce the 'compute.isin_limit' option

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33982:
URL: https://github.com/apache/spark/pull/33982#issuecomment-918644562


   **[Test build #143226 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143226/testReport)** for PR 33982 at commit [`8d06b21`](https://github.com/apache/spark/commit/8d06b21120e9fc390b230b02870e22b214dc769d).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33982: [SPARK-36748][PYTHON] Introduce the 'compute.isin_limit' option

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33982:
URL: https://github.com/apache/spark/pull/33982#issuecomment-918665515






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #33982: [SPARK-36748][PYTHON] Introduce the 'compute.isin_limit' option

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #33982:
URL: https://github.com/apache/spark/pull/33982


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #33982: [SPARK-36748][PYTHON] Introduce the 'compute.isin_limit' option

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33982:
URL: https://github.com/apache/spark/pull/33982#issuecomment-918745919


   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33982: [SPARK-36748][PYTHON] Introduce the 'compute.isin_limit' option

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33982:
URL: https://github.com/apache/spark/pull/33982#issuecomment-918665516






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33982: [SPARK-36748][PYTHON] Introduce the 'compute.isin_limit' option

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33982:
URL: https://github.com/apache/spark/pull/33982#issuecomment-918644562


   **[Test build #143226 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143226/testReport)** for PR 33982 at commit [`8d06b21`](https://github.com/apache/spark/commit/8d06b21120e9fc390b230b02870e22b214dc769d).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33982: [SPARK-36748][PYTHON] Introduce the 'compute.isin_limit' option

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33982:
URL: https://github.com/apache/spark/pull/33982#issuecomment-918662688


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47729/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33982: [SPARK-36748][PYTHON] Introduce the 'compute.isin_limit' option

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33982:
URL: https://github.com/apache/spark/pull/33982#issuecomment-918659275


   **[Test build #143226 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143226/testReport)** for PR 33982 at commit [`8d06b21`](https://github.com/apache/spark/commit/8d06b21120e9fc390b230b02870e22b214dc769d).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org