You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Eric Jablow (Created) (JIRA)" <ji...@apache.org> on 2011/11/20 06:28:51 UTC
[jira] [Created] (WICKET-4246)
WicketTester.assertFeedback(java.lang.String path, java.lang.String[]
messages) should not require feedback messages to be in the specified
order.
WicketTester.assertFeedback(java.lang.String path, java.lang.String[] messages) should not require feedback messages to be in the specified order.
--------------------------------------------------------------------------------------------------------------------------------------------------
Key: WICKET-4246
URL: https://issues.apache.org/jira/browse/WICKET-4246
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.5.3
Environment: Microsoft Windows XP 64, Mac OS X Snow Leopard
Reporter: Eric Jablow
Priority: Minor
Some validation systems validate form fields in an arbitrary order; for example, the net.ftlines.wicket-bean-validation and Hibernate Validation combination. Thus, the feedback messages may appear in arbitrary order. However, WicketTester.assertFeedback requires that the actual messages be the expected messages in their exact order. Thus, a test like:
tester.assertFeedback("feedback", new String[]{messageA, messageB});
is not especially useful.
I suggest that either assertFeedback be written to not care about the order of the messages, or that a method WicketTester.assertFeedbackInAnyOrder(String path, String[] messages) be written.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4246)
WicketTester.assertFeedback(java.lang.String path, java.lang.String[]
messages) should not require feedback messages to be in the specified
order.
Posted by "Igor Vaynberg (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-4246.
-----------------------------------
Resolution: Fixed
Fix Version/s: 6.0.0
1.5.4
Assignee: Igor Vaynberg
> WicketTester.assertFeedback(java.lang.String path, java.lang.String[] messages) should not require feedback messages to be in the specified order.
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-4246
> URL: https://issues.apache.org/jira/browse/WICKET-4246
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.3
> Environment: Microsoft Windows XP 64, Mac OS X Snow Leopard
> Reporter: Eric Jablow
> Assignee: Igor Vaynberg
> Priority: Minor
> Labels: test
> Fix For: 1.5.4, 6.0.0
>
> Attachments: assertFeedback.tgz
>
>
> Some validation systems validate form fields in an arbitrary order; for example, the net.ftlines.wicket-bean-validation and Hibernate Validation combination. Thus, the feedback messages may appear in arbitrary order. However, WicketTester.assertFeedback requires that the actual messages be the expected messages in their exact order. Thus, a test like:
> tester.assertFeedback("feedback", new String[]{messageA, messageB});
> is not especially useful.
> I suggest that either assertFeedback be written to not care about the order of the messages, or that a method WicketTester.assertFeedbackInAnyOrder(String path, String[] messages) be written.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4246)
WicketTester.assertFeedback(java.lang.String path, java.lang.String[]
messages) should not require feedback messages to be in the specified
order.
Posted by "Eric Jablow (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Jablow updated WICKET-4246:
--------------------------------
Attachment: assertFeedback.tgz
A Maven Wicket quickstart project for WICKET-4246. The TestHomePage class has two methods, validationMessagesInOrder, and validationMessagesInOtherOrder. One of these methods will fail, but the one that fails is unpredictable.
> WicketTester.assertFeedback(java.lang.String path, java.lang.String[] messages) should not require feedback messages to be in the specified order.
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-4246
> URL: https://issues.apache.org/jira/browse/WICKET-4246
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.3
> Environment: Microsoft Windows XP 64, Mac OS X Snow Leopard
> Reporter: Eric Jablow
> Priority: Minor
> Labels: test
> Attachments: assertFeedback.tgz
>
>
> Some validation systems validate form fields in an arbitrary order; for example, the net.ftlines.wicket-bean-validation and Hibernate Validation combination. Thus, the feedback messages may appear in arbitrary order. However, WicketTester.assertFeedback requires that the actual messages be the expected messages in their exact order. Thus, a test like:
> tester.assertFeedback("feedback", new String[]{messageA, messageB});
> is not especially useful.
> I suggest that either assertFeedback be written to not care about the order of the messages, or that a method WicketTester.assertFeedbackInAnyOrder(String path, String[] messages) be written.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira