You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/03/18 19:17:53 UTC
[kudu-CR] linked list-test-util: quelch warning
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15479
Change subject: linked_list-test-util: quelch warning
......................................................................
linked_list-test-util: quelch warning
I saw this when building in release mode:
../../src/kudu/util/status.h: In member function ‘void kudu::ScopedRowUpdater::RowUpdaterThread()’:
../../src/kudu/util/status.h:91:40: warning: ‘next_key’ may be used uninitialized in this function [-Wmaybe-uninitialized]
const ::kudu::Status& _s = (to_call); \
^
In file included from ../../src/kudu/integration-tests/linked_list-test.cc:50:0:
../../src/kudu/integration-tests/linked_list-test-util.h:288:13: note: ‘next_key’ was declared here
int64_t next_key;
^
Change-Id: Ic2f6d9a96b76f1e7c587a53037856001bbda9ea7
---
M src/kudu/integration-tests/linked_list-test-util.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/15479/1
--
To view, visit http://gerrit.cloudera.org:8080/15479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2f6d9a96b76f1e7c587a53037856001bbda9ea7
Gerrit-Change-Number: 15479
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] linked list-test-util: quelch warning
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15479 )
Change subject: linked_list-test-util: quelch warning
......................................................................
linked_list-test-util: quelch warning
I saw this when building in release mode:
../../src/kudu/util/status.h: In member function ‘void kudu::ScopedRowUpdater::RowUpdaterThread()’:
../../src/kudu/util/status.h:91:40: warning: ‘next_key’ may be used uninitialized in this function [-Wmaybe-uninitialized]
const ::kudu::Status& _s = (to_call); \
^
In file included from ../../src/kudu/integration-tests/linked_list-test.cc:50:0:
../../src/kudu/integration-tests/linked_list-test-util.h:288:13: note: ‘next_key’ was declared here
int64_t next_key;
^
Change-Id: Ic2f6d9a96b76f1e7c587a53037856001bbda9ea7
Reviewed-on: http://gerrit.cloudera.org:8080/15479
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/integration-tests/linked_list-test-util.h
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2f6d9a96b76f1e7c587a53037856001bbda9ea7
Gerrit-Change-Number: 15479
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] linked list-test-util: quelch warning
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15479 )
Change subject: linked_list-test-util: quelch warning
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2f6d9a96b76f1e7c587a53037856001bbda9ea7
Gerrit-Change-Number: 15479
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 18 Mar 2020 20:34:53 +0000
Gerrit-HasComments: No