You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/23 23:02:35 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request, #36971: [SPARK-39572][PYTHON][TESTS] Fix `test_daemon.py` to support IPv6
dongjoon-hyun opened a new pull request, #36971:
URL: https://github.com/apache/spark/pull/36971
### What changes were proposed in this pull request?
This PR aims to fix `test_deamon.py` to support both IPv6 additionally.
### Why are the changes needed?
To add IPv6-only test coverage.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the CIs and do the following manually.
```
$ SPARK_PREFER_IPV6=true python/run-tests.py --modules pyspark-core
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #36971: [SPARK-39572][PYTHON][TESTS] Fix `test_daemon.py` to support IPv6
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #36971: [SPARK-39572][PYTHON][TESTS] Fix `test_daemon.py` to support IPv6
URL: https://github.com/apache/spark/pull/36971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #36971: [SPARK-39572][PYTHON][TESTS] Fix `test_daemon.py` to support IPv6
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #36971:
URL: https://github.com/apache/spark/pull/36971#issuecomment-1165044900
Thank you, @HyukjinKwon ! Yes, currently, I'm running Jenkins locally. We should build IPv6 CI.
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #36971: [SPARK-39572][PYTHON][TESTS] Fix `test_daemon.py` to support IPv6
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #36971:
URL: https://github.com/apache/spark/pull/36971#issuecomment-1165039343
Maybe we can even set a scheduled job for this once the tests pass ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org