You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2020/11/08 20:51:44 UTC

[GitHub] [systemds] mboehm7 commented on pull request #1096: [SYSTEMDS-2719] Lineage exploitation in buffer pool

mboehm7 commented on pull request #1096:
URL: https://github.com/apache/systemds/pull/1096#issuecomment-723664017


   LGTM - thanks @sergred for this great feature. During the merge I just made a few tweaks: added missing license header, fixed wrong formatting (tabs over spaces), changed the way we present the new statistics, fixed the recomputation by lineage, removed an unnecessary `ExecutionContext.setVariable` (which existed before), and reverted the changes in ByteBuffer as its unrelated to the given feature (the code is still in the PR and we come back once we refactor that).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org