You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/11/01 22:28:50 UTC
Review Request 69237: Simplified 'test_exec' in new CLI to better
manage newlines.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69237/
-----------------------------------------------------------
Review request for mesos and Kevin Klues.
Bugs: MESOS-9341
https://issues.apache.org/jira/browse/MESOS-9341
Repository: mesos
Description
-------
Simplified 'test_exec' in new CLI to better manage newlines.
Diffs
-----
src/python/cli_new/lib/cli/tests/task.py 4b03cf13185f1c718f24a990a75a4dd74e7e132a
Diff: https://reviews.apache.org/r/69237/diff/1/
Testing
-------
```
(mesos-cli) ? cli_new (exec-attach) ? mesos-cli-tests
Running the Mesos CLI unit tests
TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok
TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
TestTaskPlugin
test_exec (cli.tests.task.TestTaskPlugin) ... ok
test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
test_exec_interactive (cli.tests.task.TestTaskPlugin) ... giok
test_list (cli.tests.task.TestTaskPlugin) ... commiok
----------------------------------------------------------------------
Ran 7 tests in 17.531s
OK
```
Thanks,
Armand Grillet
Re: Review Request 69237: Simplified 'test_exec' in new CLI to better
manage newlines.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69237/#review210268
-----------------------------------------------------------
PASS: Mesos patch 69237 was successfully built and tested.
Reviews applied: `['69237']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2563/mesos-review-69237
- Mesos Reviewbot Windows
On Nov. 1, 2018, 10:28 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69237/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2018, 10:28 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-9341
> https://issues.apache.org/jira/browse/MESOS-9341
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Simplified 'test_exec' in new CLI to better manage newlines.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/tests/task.py 4b03cf13185f1c718f24a990a75a4dd74e7e132a
>
>
> Diff: https://reviews.apache.org/r/69237/diff/1/
>
>
> Testing
> -------
>
> ```
> (mesos-cli) ? cli_new (exec-attach) ? mesos-cli-tests
> Running the Mesos CLI unit tests
>
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
>
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
>
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... giok
> test_list (cli.tests.task.TestTaskPlugin) ... commiok
>
> ----------------------------------------------------------------------
> Ran 7 tests in 17.531s
>
> OK
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69237: Simplified newline handling in
'test_exec()' test for new CLI.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69237/#review210303
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Nov. 1, 2018, 10:28 nachm., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69237/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2018, 10:28 nachm.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-9343
> https://issues.apache.org/jira/browse/MESOS-9343
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test was previously using '.strip()' to compare the command stdout
> and the result we expect. By replacing the task command to use 'printf'
> instead of 'echo', we are able to simplify this assertion.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/tests/task.py ce3a55d4b66ca74b6be892d058644281ee5c803d
>
>
> Diff: https://reviews.apache.org/r/69237/diff/2/
>
>
> Testing
> -------
>
> ```
> (mesos-cli) ? cli_new (exec-attach) ? mesos-cli-tests
> Running the Mesos CLI unit tests
>
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
>
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
>
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
>
> ----------------------------------------------------------------------
> Ran 7 tests in 17.238s
>
> OK
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69237: Simplified newline handling in
'test_exec()' test for new CLI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69237/#review210306
-----------------------------------------------------------
PASS: Mesos patch 69237 was successfully built and tested.
Reviews applied: `['69237']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2568/mesos-review-69237
- Mesos Reviewbot Windows
On Nov. 2, 2018, 6:28 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69237/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2018, 6:28 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-9343
> https://issues.apache.org/jira/browse/MESOS-9343
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test was previously using '.strip()' to compare the command stdout
> and the result we expect. By replacing the task command to use 'printf'
> instead of 'echo', we are able to simplify this assertion.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/tests/task.py ce3a55d4b66ca74b6be892d058644281ee5c803d
>
>
> Diff: https://reviews.apache.org/r/69237/diff/2/
>
>
> Testing
> -------
>
> ```
> (mesos-cli) ? cli_new (exec-attach) ? mesos-cli-tests
> Running the Mesos CLI unit tests
>
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
>
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
>
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
>
> ----------------------------------------------------------------------
> Ran 7 tests in 17.238s
>
> OK
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>