You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/08/16 02:54:32 UTC

[GitHub] [spark] panbingkun commented on a diff in pull request #42507: [SPARK-44823][PYTHON] Update black to 23.7.0 and fix erroneous check

panbingkun commented on code in PR #42507:
URL: https://github.com/apache/spark/pull/42507#discussion_r1295328060


##########
dev/pyproject.toml:
##########
@@ -27,8 +27,8 @@ testpaths = [
 [tool.black]
 # When changing the version, we have to update
 # GitHub workflow version and dev/reformat-python
-required-version = "22.6.0"
+required-version = "23.7.0"
 line-length = 100
 target-version = ['py38']
 include = '\.pyi?$'
-extend-exclude = 'cloudpickle|error_classes.py'
+extend-exclude = 'cloudpickle|error_classes.py|proto'

Review Comment:
   For automatically generated code, we should exclude it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org