[GitHub] [hive] mr3project removed a comment on pull request #1616: HIVE-24316. Upgrade ORC from 1.5.6 to 1.5.8 in branch-3.1

[GitBox <gi...@apache.org>]

mr3project removed a comment on pull request #1616:
URL: https://github.com/apache/hive/pull/1616#issuecomment-725902463


   Hello,
   
   This commit seems to fail four existing test cases in org.apache.hadoop.hive.ql.io.orc.TestOrcFile:
   
   [ERROR] Failures: 
   [ERROR]   TestOrcFile.testMemoryManagementV11:1992 stripe 1 is too long at 18454
   [ERROR]   TestOrcFile.testMemoryManagementV11:1992 stripe 1 is too long at 18454
   [ERROR]   TestOrcFile.testMemoryManagementV12:2029 stripe 1 is too long at 9626
   [ERROR]   TestOrcFile.testMemoryManagementV12:2029 stripe 1 is too long at 9626
   [INFO] 
   [ERROR] Tests run: 44, Failures: 4, Errors: 0, Skipped: 0
   
   In my own manual testing, the four tests succeed with HIVE-24331 (the last commit just before HIVE-24316 in branch-3.1), so there is a good chance that upgrading ORC to 1.5.8 introduces these errors.
   
   The error is generated from the following assertTrue(), so replacing the constant 5000 with 2000 would fix the errors.
   
       for(StripeInformation stripe: reader.getStripes()) {
         i += 1;
         assertTrue("stripe " + i + " is too long at " + stripe.getDataLength(),
             stripe.getDataLength() < 5000);
       }
   
   Could someone test the latest commit in branch-3.1 to see if the same errors can be reproduced? 
   
   --- Sungwoo
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org