You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by bm...@apache.org on 2020/12/07 14:37:12 UTC
[maven-checkstyle-plugin] branch MCHECKSTYLE-387 updated (b8e77df
-> d3d5285)
This is an automated email from the ASF dual-hosted git repository.
bmarwell pushed a change to branch MCHECKSTYLE-387
in repository https://gitbox.apache.org/repos/asf/maven-checkstyle-plugin.git.
discard b8e77df [MCHECKSTYLE-387] emit a warning when using an old version of checkstyle.
add 354fad1 update JUnit
add 1ec4c24 Merge pull request #37 from apache/ver
add d8522d5 remove unused dependency
add 895b91f Merge pull request #38 from apache/ver2
add 4b4101c use try with resources instead of deprecated method
add 04be4e1 Merge pull request #39 from apache/close
add bd635da remove unused imports
add 91b8b16 Merge pull request #40 from apache/ver3
new d3d5285 [MCHECKSTYLE-387] emit a warning when using an old version of checkstyle.
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (b8e77df)
\
N -- N -- N refs/heads/MCHECKSTYLE-387 (d3d5285)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
pom.xml | 7 +------
.../plugins/checkstyle/exec/DefaultCheckstyleExecutor.java | 14 ++++----------
.../maven/plugins/checkstyle/CheckstyleReportTest.java | 1 -
.../checkstyle/CheckstyleViolationCheckMojoTest.java | 1 -
.../maven/plugins/checkstyle/ReportResourceTest.java | 1 -
.../exec/CheckstyleReportListenerMultiSourceTest.java | 6 ------
.../checkstyle/exec/CheckstyleReportListenerTest.java | 3 ---
.../plugins/checkstyle/exec/CheckstyleResultsTest.java | 3 ---
8 files changed, 5 insertions(+), 31 deletions(-)
[maven-checkstyle-plugin] 01/01: [MCHECKSTYLE-387] emit a warning
when using an old version of checkstyle.
Posted by bm...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
bmarwell pushed a commit to branch MCHECKSTYLE-387
in repository https://gitbox.apache.org/repos/asf/maven-checkstyle-plugin.git
commit d3d528553ba3924c732e06465e75a754768795bc
Author: Benjamin Marwell <bm...@gmail.com>
AuthorDate: Thu Feb 27 06:51:54 2020 +0100
[MCHECKSTYLE-387] emit a warning when using an old version of checkstyle.
---
.../maven/plugins/checkstyle/exec/DefaultCheckstyleExecutor.java | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/src/main/java/org/apache/maven/plugins/checkstyle/exec/DefaultCheckstyleExecutor.java b/src/main/java/org/apache/maven/plugins/checkstyle/exec/DefaultCheckstyleExecutor.java
index 4481506..94a01e0 100644
--- a/src/main/java/org/apache/maven/plugins/checkstyle/exec/DefaultCheckstyleExecutor.java
+++ b/src/main/java/org/apache/maven/plugins/checkstyle/exec/DefaultCheckstyleExecutor.java
@@ -313,6 +313,13 @@ public class DefaultCheckstyleExecutor
try
{
checker.setClassLoader( projectClassLoader );
+ /*
+ * MCHECKSTYLE-387: If the previous method call was successful, emit a warning that the user is using
+ * an old version of checkstyle.
+ */
+ getLogger().warn( "Old version of checkstyle detected. Consider updating to >= v8.30" );
+ getLogger().warn( "For more information see: "
+ + "https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html" );
}
catch ( NoSuchMethodError ignored )
{