[GitHub] [iceberg] Fokko commented on a diff in pull request #5953: Python: Simplify the logic of caching

[GitBox <gi...@apache.org>]

Fokko commented on code in PR #5953:
URL: https://github.com/apache/iceberg/pull/5953#discussion_r993030825


##########
python/pyiceberg/io/fsspec.py:
##########
@@ -136,8 +136,6 @@ class FsspecFileIO(FileIO):
     """A FileIO implementation that uses fsspec"""
 
     def __init__(self, properties: Properties):
-        self._scheme_to_fs = {}
-        self._scheme_to_fs.update(SCHEME_TO_FS)

Review Comment:
   How would this enable this? The `_scheme_to_fs` should not be accessed from outside of the class, and currently we just take an exact copy of it..



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org