You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by sihuazhou <gi...@git.apache.org> on 2018/05/29 13:06:29 UTC

[GitHub] flink pull request #6094: [FLINK-9468][filesystem] fix get outputLimit in Li...

GitHub user sihuazhou opened a pull request:

    https://github.com/apache/flink/pull/6094

    [FLINK-9468][filesystem] fix get outputLimit in LimitedConnectionsFileSystem#createStream() incorrectly

    ## What is the purpose of the change
    
    This PR fixes the bug of getting `outputLimit` incorrectly in `LimitedConnectionsFileSystem#createStream()`.
    
    ## Brief change log
    
      - *get outputLimit in LimitedConnectionsFileSystem#createStream() correctly.*
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
    no

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sihuazhou/flink FLINK-9468

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6094.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6094
    
----
commit ed2197152725f55aafe357453e05b834e62b6076
Author: sihuazhou <su...@...>
Date:   2018-05-29T13:03:03Z

    get outputLimit in LimitedConnectionsFileSystem#createStream() correctly.

----


---

[GitHub] flink pull request #6094: [FLINK-9468][filesystem] fix calculate outputLimit...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/6094


---

[GitHub] flink issue #6094: [FLINK-9468][filesystem] fix calculate outputLimit incorr...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/6094
  
    Good catch. Apparently the tests don't check all combinations of settings, otherwise this would have shown up.
    
    Merging this...


---

[GitHub] flink issue #6094: [FLINK-9468][filesystem] fix calculate outputLimit incorr...

Posted by sihuazhou <gi...@git.apache.org>.

Github user sihuazhou commented on the issue:

    https://github.com/apache/flink/pull/6094
  
    CC @StephanEwen 


---