[jira] [Commented] (PIG-2338) Need signature for EvalFunc

["Ashutosh Chauhan (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142485#comment-13142485 ] 

Ashutosh Chauhan commented on PIG-2338:
---------------------------------------

Looks good. Few comments:
* In POUserFunc::setSignature() I think you need to do this.func.sign instead.
* I find it little awkward that signature is stored as a member variable in POUserFunc. I think it belongs in EvalFunc (or in FuncSpec).  Ideally, our loadfunc/evalfunc should be serializable so that we can get away from this storing things in jobconf and then setting them in backend. I think this should be taken care of in new UDF/LF/SF design. Will open a follow-up jira.
* Since this is a new functionality, we should add a e2e testcase covering this and PIG-2337. 
                
> Need signature for EvalFunc
> ---------------------------
>
>                 Key: PIG-2338
>                 URL: https://issues.apache.org/jira/browse/PIG-2338
>             Project: Pig
>          Issue Type: New Feature
>          Components: impl
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.11
>
>         Attachments: PIG-2338-1.patch, PIG-2338-1_0.9.patch
>
>
> In LoadFunc/StoreFunc, we generate a unique signature for each LoadFunc/StoreFunc, so user can use it as key to retrieve properties in UDFContext. We need a similar mechanism for EvalFunc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira