You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/26 03:28:28 UTC

[GitHub] [tvm] monklof commented on a change in pull request #7496: [Frontend,TOPI] Improve dynamism for BatchMatmul and Dense

monklof commented on a change in pull request #7496:
URL: https://github.com/apache/tvm/pull/7496#discussion_r583359611



##########
File path: python/tvm/topi/cuda/dense.py
##########
@@ -42,11 +42,8 @@ def dense_cublas(cfg, data, weight, bias=None, out_dtype=None):
     batch, in_dim = data.shape
     out_dim, _ = weight.shape
     matmul = cublas.matmul(data, weight, False, True)
-    if isinstance(batch, int):
+    if isinstance(batch, int) and isinstance(in_dim, int) and isinstance(out_dim, int):

Review comment:
       Thanks. I'm confusing about this, under what circumstances will batch be tir.IntImm ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org