You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/08/01 01:21:46 UTC
Review Request 13176: Cleaned up the pre-installed "wrappers".
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13176/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
bin/gdb-mesos-local.sh.in b30f55f26602648517492c46b4253b95bacb13dd
bin/gdb-mesos-master.sh.in 35812eb262ed03fef2d4c718ba17fd1f21ad492a
bin/gdb-mesos-slave.sh.in cfa576ed4e501568ca571cc01fc91b55a00f472d
bin/gdb-mesos-tests.sh.in 7179d5500af1dc7ed23ba24e783d973fecff00c6
bin/mesos-local-flags.sh.in PRE-CREATION
bin/mesos-local.sh.in 4910cc971e3b343ec65f04f7b4e334d0e2a7fc7d
bin/mesos-master-flags.sh.in PRE-CREATION
bin/mesos-master.sh.in 51118f3c1c569751063fa39a073532567d863089
bin/mesos-slave-flags.sh.in PRE-CREATION
bin/mesos-slave.sh.in 1877ef51678088e9708653060b70130007fcf2ab
bin/mesos-tests-flags.sh.in PRE-CREATION
bin/mesos-tests.sh.in f23403591145dd68ccf46871d762d07cceac8184
configure.ac 15ada8f84455ed21174f4d831cf3cf1aec3aea73
Diff: https://reviews.apache.org/r/13176/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 13176: Cleaned up the pre-installed "wrappers".
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13176/#review24396
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On July 31, 2013, 11:21 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13176/
> -----------------------------------------------------------
>
> (Updated July 31, 2013, 11:21 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> bin/gdb-mesos-local.sh.in b30f55f26602648517492c46b4253b95bacb13dd
> bin/gdb-mesos-master.sh.in 35812eb262ed03fef2d4c718ba17fd1f21ad492a
> bin/gdb-mesos-slave.sh.in cfa576ed4e501568ca571cc01fc91b55a00f472d
> bin/gdb-mesos-tests.sh.in 7179d5500af1dc7ed23ba24e783d973fecff00c6
> bin/mesos-local-flags.sh.in PRE-CREATION
> bin/mesos-local.sh.in 4910cc971e3b343ec65f04f7b4e334d0e2a7fc7d
> bin/mesos-master-flags.sh.in PRE-CREATION
> bin/mesos-master.sh.in 51118f3c1c569751063fa39a073532567d863089
> bin/mesos-slave-flags.sh.in PRE-CREATION
> bin/mesos-slave.sh.in 1877ef51678088e9708653060b70130007fcf2ab
> bin/mesos-tests-flags.sh.in PRE-CREATION
> bin/mesos-tests.sh.in f23403591145dd68ccf46871d762d07cceac8184
> configure.ac 15ada8f84455ed21174f4d831cf3cf1aec3aea73
>
> Diff: https://reviews.apache.org/r/13176/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 13176: Cleaned up the pre-installed "wrappers".
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Aug. 1, 2013, 12:08 a.m., Vinod Kone wrote:
> > bin/mesos-tests-flags.sh.in, line 17
> > <https://reviews.apache.org/r/13176/diff/1/?file=331633#file331633line17>
> >
> > unused?
I'll add a comment explaining that this is currently empty but here as a placeholder.
> On Aug. 1, 2013, 12:08 a.m., Vinod Kone wrote:
> > bin/mesos-tests.sh.in, line 22
> > <https://reviews.apache.org/r/13176/diff/1/?file=331634#file331634line22>
> >
> > no-op?
See above.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13176/#review24394
-----------------------------------------------------------
On July 31, 2013, 11:21 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13176/
> -----------------------------------------------------------
>
> (Updated July 31, 2013, 11:21 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> bin/gdb-mesos-local.sh.in b30f55f26602648517492c46b4253b95bacb13dd
> bin/gdb-mesos-master.sh.in 35812eb262ed03fef2d4c718ba17fd1f21ad492a
> bin/gdb-mesos-slave.sh.in cfa576ed4e501568ca571cc01fc91b55a00f472d
> bin/gdb-mesos-tests.sh.in 7179d5500af1dc7ed23ba24e783d973fecff00c6
> bin/mesos-local-flags.sh.in PRE-CREATION
> bin/mesos-local.sh.in 4910cc971e3b343ec65f04f7b4e334d0e2a7fc7d
> bin/mesos-master-flags.sh.in PRE-CREATION
> bin/mesos-master.sh.in 51118f3c1c569751063fa39a073532567d863089
> bin/mesos-slave-flags.sh.in PRE-CREATION
> bin/mesos-slave.sh.in 1877ef51678088e9708653060b70130007fcf2ab
> bin/mesos-tests-flags.sh.in PRE-CREATION
> bin/mesos-tests.sh.in f23403591145dd68ccf46871d762d07cceac8184
> configure.ac 15ada8f84455ed21174f4d831cf3cf1aec3aea73
>
> Diff: https://reviews.apache.org/r/13176/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 13176: Cleaned up the pre-installed "wrappers".
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Aug. 1, 2013, 12:08 a.m., Vinod Kone wrote:
> > bin/mesos-slave-flags.sh.in, lines 24-26
> > <https://reviews.apache.org/r/13176/diff/1/?file=331631#file331631line24>
> >
> > s/libmesos/limesos-@{VERSION}/
> >
> > to be consistent with how we do inside launcher and test environment?
Done.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13176/#review24394
-----------------------------------------------------------
On July 31, 2013, 11:21 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13176/
> -----------------------------------------------------------
>
> (Updated July 31, 2013, 11:21 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> bin/gdb-mesos-local.sh.in b30f55f26602648517492c46b4253b95bacb13dd
> bin/gdb-mesos-master.sh.in 35812eb262ed03fef2d4c718ba17fd1f21ad492a
> bin/gdb-mesos-slave.sh.in cfa576ed4e501568ca571cc01fc91b55a00f472d
> bin/gdb-mesos-tests.sh.in 7179d5500af1dc7ed23ba24e783d973fecff00c6
> bin/mesos-local-flags.sh.in PRE-CREATION
> bin/mesos-local.sh.in 4910cc971e3b343ec65f04f7b4e334d0e2a7fc7d
> bin/mesos-master-flags.sh.in PRE-CREATION
> bin/mesos-master.sh.in 51118f3c1c569751063fa39a073532567d863089
> bin/mesos-slave-flags.sh.in PRE-CREATION
> bin/mesos-slave.sh.in 1877ef51678088e9708653060b70130007fcf2ab
> bin/mesos-tests-flags.sh.in PRE-CREATION
> bin/mesos-tests.sh.in f23403591145dd68ccf46871d762d07cceac8184
> configure.ac 15ada8f84455ed21174f4d831cf3cf1aec3aea73
>
> Diff: https://reviews.apache.org/r/13176/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 13176: Cleaned up the pre-installed "wrappers".
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13176/#review24394
-----------------------------------------------------------
bin/mesos-slave-flags.sh.in
<https://reviews.apache.org/r/13176/#comment48265>
s/libmesos/limesos-@{VERSION}/
to be consistent with how we do inside launcher and test environment?
bin/mesos-tests-flags.sh.in
<https://reviews.apache.org/r/13176/#comment48266>
unused?
bin/mesos-tests.sh.in
<https://reviews.apache.org/r/13176/#comment48267>
no-op?
- Vinod Kone
On July 31, 2013, 11:21 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13176/
> -----------------------------------------------------------
>
> (Updated July 31, 2013, 11:21 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> bin/gdb-mesos-local.sh.in b30f55f26602648517492c46b4253b95bacb13dd
> bin/gdb-mesos-master.sh.in 35812eb262ed03fef2d4c718ba17fd1f21ad492a
> bin/gdb-mesos-slave.sh.in cfa576ed4e501568ca571cc01fc91b55a00f472d
> bin/gdb-mesos-tests.sh.in 7179d5500af1dc7ed23ba24e783d973fecff00c6
> bin/mesos-local-flags.sh.in PRE-CREATION
> bin/mesos-local.sh.in 4910cc971e3b343ec65f04f7b4e334d0e2a7fc7d
> bin/mesos-master-flags.sh.in PRE-CREATION
> bin/mesos-master.sh.in 51118f3c1c569751063fa39a073532567d863089
> bin/mesos-slave-flags.sh.in PRE-CREATION
> bin/mesos-slave.sh.in 1877ef51678088e9708653060b70130007fcf2ab
> bin/mesos-tests-flags.sh.in PRE-CREATION
> bin/mesos-tests.sh.in f23403591145dd68ccf46871d762d07cceac8184
> configure.ac 15ada8f84455ed21174f4d831cf3cf1aec3aea73
>
> Diff: https://reviews.apache.org/r/13176/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>