You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/11/15 21:51:06 UTC
[GitHub] [brooklyn-server] duncangrant opened a new pull request #1273: Add useful initialisers to the catalog
duncangrant opened a new pull request #1273:
URL: https://github.com/apache/brooklyn-server/pull/1273
In order to add initialisers to the catalog I've had to make them non-final and add public no-arg constructors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] duncangrant commented on a change in pull request #1273: Add useful initialisers to the catalog
Posted by GitBox <gi...@apache.org>.
duncangrant commented on a change in pull request #1273:
URL: https://github.com/apache/brooklyn-server/pull/1273#discussion_r750404661
##########
File path: core/src/test/java/org/apache/brooklyn/core/test/BrooklynAppLiveTestSupport.java
##########
@@ -36,10 +36,17 @@
@Override
@BeforeMethod(alwaysRun=true)
public void setUp() throws Exception {
+
if (mgmt!=null) {
app = mgmt.getEntityManager().createEntity(newAppSpec());
} else {
- mgmt = new LocalManagementContextForTests(BrooklynProperties.Factory.newDefault());
+
+ LocalManagementContextForTests.Builder builder = LocalManagementContextForTests.builder(true).
+ setOsgiEnablementAndReuse(true, true);
+ if (true) {
+ builder.useDefaultProperties();
+ }
Review comment:
I must have messed up a rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] duncangrant commented on a change in pull request #1273: Add useful initialisers to the catalog
Posted by GitBox <gi...@apache.org>.
duncangrant commented on a change in pull request #1273:
URL: https://github.com/apache/brooklyn-server/pull/1273#discussion_r750404251
##########
File path: core/src/test/java/org/apache/brooklyn/core/test/BrooklynAppLiveTestSupport.java
##########
@@ -36,10 +36,17 @@
@Override
@BeforeMethod(alwaysRun=true)
public void setUp() throws Exception {
+
if (mgmt!=null) {
app = mgmt.getEntityManager().createEntity(newAppSpec());
} else {
- mgmt = new LocalManagementContextForTests(BrooklynProperties.Factory.newDefault());
+
+ LocalManagementContextForTests.Builder builder = LocalManagementContextForTests.builder(true).
+ setOsgiEnablementAndReuse(true, true);
+ if (true) {
+ builder.useDefaultProperties();
+ }
Review comment:
I'm not sure where this change has come from - I don't have it locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] algairim commented on a change in pull request #1273: Add useful initialisers to the catalog
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #1273:
URL: https://github.com/apache/brooklyn-server/pull/1273#discussion_r750058677
##########
File path: core/src/test/java/org/apache/brooklyn/core/test/BrooklynAppLiveTestSupport.java
##########
@@ -36,10 +36,17 @@
@Override
@BeforeMethod(alwaysRun=true)
public void setUp() throws Exception {
+
if (mgmt!=null) {
app = mgmt.getEntityManager().createEntity(newAppSpec());
} else {
- mgmt = new LocalManagementContextForTests(BrooklynProperties.Factory.newDefault());
+
+ LocalManagementContextForTests.Builder builder = LocalManagementContextForTests.builder(true).
+ setOsgiEnablementAndReuse(true, true);
+ if (true) {
+ builder.useDefaultProperties();
+ }
Review comment:
Does not look like `if` statement needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] algairim commented on a change in pull request #1273: Add useful initialisers to the catalog
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #1273:
URL: https://github.com/apache/brooklyn-server/pull/1273#discussion_r750059037
##########
File path: core/src/test/java/org/apache/brooklyn/core/test/BrooklynAppLiveTestSupport.java
##########
@@ -36,10 +36,17 @@
@Override
@BeforeMethod(alwaysRun=true)
public void setUp() throws Exception {
+
if (mgmt!=null) {
app = mgmt.getEntityManager().createEntity(newAppSpec());
} else {
- mgmt = new LocalManagementContextForTests(BrooklynProperties.Factory.newDefault());
+
+ LocalManagementContextForTests.Builder builder = LocalManagementContextForTests.builder(true).
+ setOsgiEnablementAndReuse(true, true);
+ if (true) {
+ builder.useDefaultProperties();
+ }
Review comment:
I mean, `if (true)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] duncangrant merged pull request #1273: Add useful initialisers to the catalog
Posted by GitBox <gi...@apache.org>.
duncangrant merged pull request #1273:
URL: https://github.com/apache/brooklyn-server/pull/1273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org