[GitHub] [arrow] nealrichardson commented on a change in pull request #8256: ARROW-9001: [R] Box outputs as correct type in call_function

[GitBox <gi...@apache.org>]

nealrichardson commented on a change in pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#discussion_r494402171



##########
File path: r/R/compute.R
##########
@@ -127,15 +127,15 @@ match_arrow.Array <- function(x, table, ...) {
   if (!inherits(table, c("Array", "ChunkedArray"))) {
     table <- Array$create(table)
   }
-  Array$create(call_function("index_in_meta_binary", x, table))
+  call_function("index_in_meta_binary", x, table)
 }
 
 #' @export
 match_arrow.ChunkedArray <- function(x, table, ...) {
   if (!inherits(table, c("Array", "ChunkedArray"))) {
     table <- Array$create(table)
   }
-  shared_ptr(ChunkedArray, call_function("index_in_meta_binary", x, table))
+  call_function("index_in_meta_binary", x, table)
 }

Review comment:
       This can be `match_arrow.ChunkedArray <- match_arrow.Array` now since they're the same. There are probably a few others like this (I see `Ops` also, for example).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org