You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/05/08 21:52:41 UTC

Review Request 33996: Implement HdfsResouces and it's usage

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/
-----------------------------------------------------------

Review request for Ambari and Mahadev Konar.


Bugs: AMBARI-11034
    https://issues.apache.org/jira/browse/AMBARI-11034


Repository: ambari


Description
-------


Diffs
-----

  ambari-agent/pom.xml a08e81c 
  ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
  ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
  ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
  ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
  ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
  ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
  ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
  ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
  ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
  ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
  ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
  ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
  ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
  ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
  ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
  ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 5bb80de 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 59ebb6c1 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py d8d99d5 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 5e0096f 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 5875284 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py c4fb033 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py f430743 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 5db3422 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ae736de 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
  ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
  ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
  ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
  ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
  ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
  ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
  contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
  contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
  contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
  contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
  contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
  contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 

Diff: https://reviews.apache.org/r/33996/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Andrew Onischuk <ao...@hortonworks.com>.

> On May 8, 2015, 9:06 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py, line 19
> > <https://reviews.apache.org/r/33996/diff/3/?file=953643#file953643line19>
> >
> >     Is this line needed?

Seems after merging the patch I got this. Thanks Sumit!


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/#review83090
-----------------------------------------------------------


On May 8, 2015, 8:55 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33996/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 8:55 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11034
>     https://issues.apache.org/jira/browse/AMBARI-11034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> -
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml a08e81c 
>   ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
>   ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
>   ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
>   ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
>   ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
>   ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
>   ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
>   ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py f1b8ae5 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py aec8e23 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 82a6351 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 47ce98a 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 6909cd7 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py 93c8c71 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 4130472 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 7f17a26 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ee454b6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
>   contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33996/diff/
> 
> 
> Testing
> -------
> 
> tested HA + non-secure/secure - 2.3 stack
> tested non-secure/secure - 2.2 stack
> tested deploy - stack 2.0
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/#review83090
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
<https://reviews.apache.org/r/33996/#comment133960>

    Is this line needed?


- Sumit Mohanty


On May 8, 2015, 8:55 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33996/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 8:55 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11034
>     https://issues.apache.org/jira/browse/AMBARI-11034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> -
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml a08e81c 
>   ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
>   ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
>   ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
>   ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
>   ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
>   ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
>   ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
>   ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py f1b8ae5 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py aec8e23 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 82a6351 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 47ce98a 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 6909cd7 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py 93c8c71 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 4130472 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 7f17a26 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ee454b6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
>   contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33996/diff/
> 
> 
> Testing
> -------
> 
> tested HA + non-secure/secure - 2.3 stack
> tested non-secure/secure - 2.2 stack
> tested deploy - stack 2.0
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Andrew Onischuk <ao...@hortonworks.com>.

> On May 8, 2015, 9:18 p.m., Sumit Mohanty wrote:
> > What is the best place to put this logic now? It was in dynamic_variable_interpretation.py?
> > 
> > if not ignore_sysprep and hasattr(params, "host_sys_prepped") and params.host_sys_prepped:
> >     Logger.info("Host is sys-prepped. Tarball %s will not be copied for %s." % (tarball_prefix, hdp_select_component_name))
> >     return 0

in HdfsResouce in action_execute before this:

    # Execute jar to create/delete resources in hadoop
    Execute(format("hadoop --config {hadoop_conf_dir} jar {jar_path} {json_path}"),
            user=user,
            path=[hadoop_bin_dir],
            logoutput=logoutput,
    )


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/#review83091
-----------------------------------------------------------


On May 8, 2015, 9:11 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33996/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 9:11 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11034
>     https://issues.apache.org/jira/browse/AMBARI-11034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> -
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml a08e81c 
>   ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
>   ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
>   ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
>   ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
>   ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
>   ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
>   ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
>   ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py f1b8ae5 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py aec8e23 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 82a6351 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 47ce98a 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 6909cd7 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py 93c8c71 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 4130472 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 7f17a26 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ee454b6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
>   contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33996/diff/
> 
> 
> Testing
> -------
> 
> tested HA + non-secure/secure - 2.3 stack
> tested non-secure/secure - 2.2 stack
> tested deploy - stack 2.0
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Andrew Onischuk <ao...@hortonworks.com>.

> On May 8, 2015, 9:18 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py, line 166
> > <https://reviews.apache.org/r/33996/diff/3/?file=953648#file953648line166>
> >
> >     Same issue, HBase RS may get installed/started first

No it cannot start first because:
"HBASE_REGIONSERVER-START": ["HBASE_MASTER-START"],
in role_command_order

install oreder doesn't matter


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/#review83091
-----------------------------------------------------------


On May 8, 2015, 9:11 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33996/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 9:11 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11034
>     https://issues.apache.org/jira/browse/AMBARI-11034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> -
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml a08e81c 
>   ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
>   ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
>   ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
>   ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
>   ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
>   ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
>   ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
>   ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py f1b8ae5 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py aec8e23 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 82a6351 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 47ce98a 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 6909cd7 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py 93c8c71 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 4130472 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 7f17a26 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ee454b6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
>   contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33996/diff/
> 
> 
> Testing
> -------
> 
> tested HA + non-secure/secure - 2.3 stack
> tested non-secure/secure - 2.2 stack
> tested deploy - stack 2.0
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/#review83091
-----------------------------------------------------------


What is the best place to put this logic now? It was in dynamic_variable_interpretation.py?

if not ignore_sysprep and hasattr(params, "host_sys_prepped") and params.host_sys_prepped:
    Logger.info("Host is sys-prepped. Tarball %s will not be copied for %s." % (tarball_prefix, hdp_select_component_name))
    return 0


ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
<https://reviews.apache.org/r/33996/#comment133961>

    Same issue, HBase RS may get installed/started first


- Sumit Mohanty


On May 8, 2015, 9:11 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33996/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 9:11 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11034
>     https://issues.apache.org/jira/browse/AMBARI-11034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> -
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml a08e81c 
>   ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
>   ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
>   ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
>   ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
>   ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
>   ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
>   ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
>   ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py f1b8ae5 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py aec8e23 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 82a6351 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 47ce98a 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 6909cd7 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py 93c8c71 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 4130472 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 7f17a26 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ee454b6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
>   contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33996/diff/
> 
> 
> Testing
> -------
> 
> tested HA + non-secure/secure - 2.3 stack
> tested non-secure/secure - 2.2 stack
> tested deploy - stack 2.0
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/#review83139
-----------------------------------------------------------


Alejandro, attached additional patch with the fixes haven't yet tested but can you please see if the concept is correct?

- Andrew Onischuk


On May 9, 2015, 8:14 a.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33996/
> -----------------------------------------------------------
> 
> (Updated May 9, 2015, 8:14 a.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11034
>     https://issues.apache.org/jira/browse/AMBARI-11034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> -
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/ambari_commons/constants.py 99ff679 
>   ambari-common/src/main/python/resource_management/libraries/functions/get_hdp_version.py ed34c02 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py d9f20da 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 7a3401e 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 421a981 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 39e4b97 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py a33857c 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 89f0224 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 8b5db38 
> 
> Diff: https://reviews.apache.org/r/33996/diff/
> 
> 
> Testing
> -------
> 
> tested HA + non-secure/secure - 2.3 stack
> tested non-secure/secure - 2.2 stack
> tested deploy - stack 2.0
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/
-----------------------------------------------------------

(Updated May 9, 2015, 8:35 a.m.)


Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-11034
    https://issues.apache.org/jira/browse/AMBARI-11034


Repository: ambari


Description
-------

-


Diffs (updated)
-----

  ambari-common/src/main/python/ambari_commons/constants.py 99ff679 
  ambari-common/src/main/python/resource_management/libraries/functions/get_hdp_version.py ed34c02 
  ambari-common/src/main/python/resource_management/libraries/functions/version.py d9f20da 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 7a3401e 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 421a981 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 39e4b97 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py a33857c 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 89f0224 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py ddb829e 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 2600141 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 8b5db38 
  ambari-server/src/main/resources/stacks/HDP/2.2/configuration/cluster-env.xml 281b821 

Diff: https://reviews.apache.org/r/33996/diff/


Testing
-------

tested HA + non-secure/secure - 2.3 stack
tested non-secure/secure - 2.2 stack
tested deploy - stack 2.0

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/
-----------------------------------------------------------

(Updated May 9, 2015, 8:14 a.m.)


Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-11034
    https://issues.apache.org/jira/browse/AMBARI-11034


Repository: ambari


Description
-------

-


Diffs (updated)
-----

  ambari-common/src/main/python/ambari_commons/constants.py 99ff679 
  ambari-common/src/main/python/resource_management/libraries/functions/get_hdp_version.py ed34c02 
  ambari-common/src/main/python/resource_management/libraries/functions/version.py d9f20da 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 7a3401e 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 421a981 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 39e4b97 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py a33857c 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 89f0224 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 8b5db38 

Diff: https://reviews.apache.org/r/33996/diff/


Testing
-------

tested HA + non-secure/secure - 2.3 stack
tested non-secure/secure - 2.2 stack
tested deploy - stack 2.0

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/#review83112
-----------------------------------------------------------


Alejandro, really appreciate you review comments. Can you please create a new jira and assign that to me, with the things you think should be changed. I'm gonna fix in short terms

- Andrew Onischuk


On May 8, 2015, 9:11 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33996/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 9:11 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11034
>     https://issues.apache.org/jira/browse/AMBARI-11034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> -
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml a08e81c 
>   ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
>   ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
>   ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
>   ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
>   ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
>   ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
>   ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
>   ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py f1b8ae5 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py aec8e23 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 82a6351 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 47ce98a 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 6909cd7 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py 93c8c71 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 4130472 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 7f17a26 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ee454b6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
>   contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33996/diff/
> 
> 
> Testing
> -------
> 
> tested HA + non-secure/secure - 2.3 stack
> tested non-secure/secure - 2.2 stack
> tested deploy - stack 2.0
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Andrew Onischuk <ao...@hortonworks.com>.

> On May 8, 2015, 10:13 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py, line 293
> > <https://reviews.apache.org/r/33996/diff/4/?file=953767#file953767line293>
> >
> >     This  may need type="directory"

This is just a partial function defenition, it only includes the basic default things, type is gonna be used on actual resource usage


> On May 8, 2015, 10:13 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py, line 145
> > <https://reviews.apache.org/r/33996/diff/4/?file=953760#file953760line145>
> >
> >     Where is is_empty defined?
> >     Can we initialize queryserver_jaas_princ in all cases,
> >     
> >     E.g., 
> >     
> >     queryserver_jaas_princ = _queryserver_jaas_princ.replace('_HOST',_hostname_lowercase) if not is_empty(_queryserver_jaas_princ) else None

queryserver is a part of HDP-2.3 only. I don't think we need that in previous stacks


> On May 8, 2015, 10:13 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py, line 106
> > <https://reviews.apache.org/r/33996/diff/4/?file=953772#file953772line106>
> >
> >     This design is going to change because keeping the source and destination in cluster-env properties is not very good. And the source location will no longer be a constant value.

I think it's a target for other jira, this is for optimizing cluster time performance


> On May 8, 2015, 10:13 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py, line 94
> > <https://reviews.apache.org/r/33996/diff/4/?file=953770#file953770line94>
> >
> >     Copying tarballs needs some discussion. It's pretty messy right now and there's a bug right now copying the tarballs during a Rolling Upgrade that causes it to be copied from the wrong location.
> >     I'll set up a call on Monday morning PST.

it seem to work like before, I've tested that I'm not into RU a lot I think this is a different jira issue.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/#review83103
-----------------------------------------------------------


On May 8, 2015, 9:11 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33996/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 9:11 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11034
>     https://issues.apache.org/jira/browse/AMBARI-11034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> -
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml a08e81c 
>   ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
>   ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
>   ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
>   ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
>   ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
>   ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
>   ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
>   ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py f1b8ae5 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py aec8e23 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 82a6351 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 47ce98a 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 6909cd7 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py 93c8c71 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 4130472 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 7f17a26 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ee454b6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
>   contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33996/diff/
> 
> 
> Testing
> -------
> 
> tested HA + non-secure/secure - 2.3 stack
> tested non-secure/secure - 2.2 stack
> tested deploy - stack 2.0
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/#review83103
-----------------------------------------------------------



ambari-common/src/main/python/resource_management/libraries/functions/version.py
<https://reviews.apache.org/r/33996/#comment133964>

    Why the comparison with 2.2.0.0?



ambari-common/src/main/python/resource_management/libraries/functions/version.py
<https://reviews.apache.org/r/33996/#comment133965>

    This may not work. hdp-select status will report every possible symlink, even those for components that are not installed on the host.
    So if a user upgrades from say HDP 2.2.0.0-2041 to 2.2.4.2-2, it's still possible that the former value will be returned.
    It may be better to get the version of the stack from the database (cluster_version table), and pass it as a param to the python files



ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py
<https://reviews.apache.org/r/33996/#comment133966>

    We should use named imports, same goes for a lot of the other files.



ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
<https://reviews.apache.org/r/33996/#comment133967>

    Import HadoopResource insead of *



ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
<https://reviews.apache.org/r/33996/#comment133968>

    Import HadoopResource insead of *



ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
<https://reviews.apache.org/r/33996/#comment133969>

    Where is is_empty defined?
    Can we initialize queryserver_jaas_princ in all cases,
    
    E.g., 
    
    queryserver_jaas_princ = _queryserver_jaas_princ.replace('_HOST',_hostname_lowercase) if not is_empty(_queryserver_jaas_princ) else None



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
<https://reviews.apache.org/r/33996/#comment133970>

    Can we move this to constants.py



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
<https://reviews.apache.org/r/33996/#comment133971>

    This  may need type="directory"



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py
<https://reviews.apache.org/r/33996/#comment133972>

    This is a good optimization



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
<https://reviews.apache.org/r/33996/#comment133974>

    Don't need major, can just compare against "2.2.0.0"



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
<https://reviews.apache.org/r/33996/#comment133975>

    Copying tarballs needs some discussion. It's pretty messy right now and there's a bug right now copying the tarballs during a Rolling Upgrade that causes it to be copied from the wrong location.
    I'll set up a call on Monday morning PST.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
<https://reviews.apache.org/r/33996/#comment133976>

    Hive needs both mapreduce and tez tarballs.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
<https://reviews.apache.org/r/33996/#comment133977>

    This design is going to change because keeping the source and destination in cluster-env properties is not very good. And the source location will no longer be a constant value.


- Alejandro Fernandez


On May 8, 2015, 9:11 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33996/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 9:11 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11034
>     https://issues.apache.org/jira/browse/AMBARI-11034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> -
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml a08e81c 
>   ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
>   ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
>   ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
>   ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
>   ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
>   ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
>   ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
>   ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py f1b8ae5 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py aec8e23 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 82a6351 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 47ce98a 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 6909cd7 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py 93c8c71 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 4130472 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 7f17a26 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ee454b6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
>   contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33996/diff/
> 
> 
> Testing
> -------
> 
> tested HA + non-secure/secure - 2.3 stack
> tested non-secure/secure - 2.2 stack
> tested deploy - stack 2.0
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Andrew Onischuk <ao...@hortonworks.com>.

> On May 8, 2015, 9:22 p.m., Sumit Mohanty wrote:
> > Overall, very good set of changes.

Thanks Sumit :)


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/#review83098
-----------------------------------------------------------


On May 8, 2015, 9:11 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33996/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 9:11 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11034
>     https://issues.apache.org/jira/browse/AMBARI-11034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> -
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml a08e81c 
>   ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
>   ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
>   ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
>   ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
>   ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
>   ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
>   ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
>   ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py f1b8ae5 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py aec8e23 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 82a6351 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 47ce98a 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 6909cd7 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py 93c8c71 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 4130472 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 7f17a26 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ee454b6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
>   contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33996/diff/
> 
> 
> Testing
> -------
> 
> tested HA + non-secure/secure - 2.3 stack
> tested non-secure/secure - 2.2 stack
> tested deploy - stack 2.0
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/#review83098
-----------------------------------------------------------


Overall, very good set of changes.

- Sumit Mohanty


On May 8, 2015, 9:11 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33996/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 9:11 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11034
>     https://issues.apache.org/jira/browse/AMBARI-11034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> -
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml a08e81c 
>   ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
>   ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
>   ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
>   ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
>   ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
>   ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
>   ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
>   ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py f1b8ae5 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py aec8e23 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 82a6351 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 47ce98a 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 6909cd7 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py 93c8c71 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 4130472 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 7f17a26 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ee454b6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
>   contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33996/diff/
> 
> 
> Testing
> -------
> 
> tested HA + non-secure/secure - 2.3 stack
> tested non-secure/secure - 2.2 stack
> tested deploy - stack 2.0
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/#review83107
-----------------------------------------------------------

Ship it!


Ship It!

- Jaimin Jetly


On May 8, 2015, 9:11 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33996/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 9:11 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11034
>     https://issues.apache.org/jira/browse/AMBARI-11034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> -
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml a08e81c 
>   ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
>   ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
>   ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
>   ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
>   ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
>   ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
>   ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
>   ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py f1b8ae5 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py aec8e23 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 82a6351 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 47ce98a 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 6909cd7 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py 93c8c71 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 4130472 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 7f17a26 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ee454b6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
>   contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33996/diff/
> 
> 
> Testing
> -------
> 
> tested HA + non-secure/secure - 2.3 stack
> tested non-secure/secure - 2.2 stack
> tested deploy - stack 2.0
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Andrew Onischuk <ao...@hortonworks.com>.

> On May 8, 2015, 9:21 p.m., Sumit Mohanty wrote:
> > How does the scenario where a mix of wasb:// and hdfs:// file systems are used work now? Can the jar work irrespective of the underlying file system?

Tested the jar on wasb:// cluster Mahadev gave me works fine. I made it use FileSystem interface (basically working similar to hadoop fs -), I took schema getting part from there.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/#review83096
-----------------------------------------------------------


On May 8, 2015, 9:11 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33996/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 9:11 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11034
>     https://issues.apache.org/jira/browse/AMBARI-11034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> -
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml a08e81c 
>   ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
>   ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
>   ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
>   ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
>   ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
>   ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
>   ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
>   ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py f1b8ae5 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py aec8e23 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 82a6351 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 47ce98a 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 6909cd7 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py 93c8c71 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 4130472 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 7f17a26 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ee454b6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
>   contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33996/diff/
> 
> 
> Testing
> -------
> 
> tested HA + non-secure/secure - 2.3 stack
> tested non-secure/secure - 2.2 stack
> tested deploy - stack 2.0
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/#review83096
-----------------------------------------------------------


How does the scenario where a mix of wasb:// and hdfs:// file systems are used work now? Can the jar work irrespective of the underlying file system?

- Sumit Mohanty


On May 8, 2015, 9:11 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33996/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 9:11 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11034
>     https://issues.apache.org/jira/browse/AMBARI-11034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> -
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml a08e81c 
>   ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
>   ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
>   ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
>   ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
>   ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
>   ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
>   ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
>   ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py f1b8ae5 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py aec8e23 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 82a6351 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 47ce98a 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 6909cd7 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py 93c8c71 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 4130472 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 7f17a26 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ee454b6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
>   contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33996/diff/
> 
> 
> Testing
> -------
> 
> tested HA + non-secure/secure - 2.3 stack
> tested non-secure/secure - 2.2 stack
> tested deploy - stack 2.0
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/
-----------------------------------------------------------

(Updated May 8, 2015, 9:11 p.m.)


Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-11034
    https://issues.apache.org/jira/browse/AMBARI-11034


Repository: ambari


Description
-------

-


Diffs (updated)
-----

  ambari-agent/pom.xml a08e81c 
  ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
  ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
  ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
  ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
  ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
  ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
  ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
  ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
  ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
  ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
  ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
  ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
  ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
  ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
  ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
  ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py f1b8ae5 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py aec8e23 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 82a6351 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 47ce98a 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 6909cd7 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py 93c8c71 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 4130472 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 7f17a26 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ee454b6 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
  ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
  ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
  ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
  ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
  ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
  ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
  contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
  contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
  contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
  contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
  contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
  contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 

Diff: https://reviews.apache.org/r/33996/diff/


Testing
-------

tested HA + non-secure/secure - 2.3 stack
tested non-secure/secure - 2.2 stack
tested deploy - stack 2.0

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/
-----------------------------------------------------------

(Updated May 8, 2015, 8:55 p.m.)


Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-11034
    https://issues.apache.org/jira/browse/AMBARI-11034


Repository: ambari


Description
-------

-


Diffs (updated)
-----

  ambari-agent/pom.xml a08e81c 
  ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
  ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
  ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
  ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
  ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
  ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
  ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
  ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
  ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
  ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
  ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
  ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
  ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
  ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
  ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
  ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py f1b8ae5 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py aec8e23 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 82a6351 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 47ce98a 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 6909cd7 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py 93c8c71 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 4130472 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 7f17a26 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ee454b6 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
  ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
  ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
  ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
  ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
  ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
  ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
  contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
  contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
  contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
  contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
  contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
  contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 

Diff: https://reviews.apache.org/r/33996/diff/


Testing
-------

tested HA + non-secure/secure - 2.3 stack
tested non-secure/secure - 2.2 stack
tested deploy - stack 2.0

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Sumit Mohanty <sm...@hortonworks.com>.

> On May 8, 2015, 8:46 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py, line 78
> > <https://reviews.apache.org/r/33996/diff/1/?file=953323#file953323line78>
> >
> >     Why tserver got removed?
> 
> Andrew Onischuk wrote:
>     due to role_command_order master always starts first to need to hdfs create dirs both times.

This assumption is not valid. A change was made recently to allow hosts to get progressively added as they come. So tserver can start first if the host where tserver is mapped to gets registered first.


> On May 8, 2015, 8:46 p.m., Sumit Mohanty wrote:
> > ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py, line 25
> > <https://reviews.apache.org/r/33996/diff/1/?file=953317#file953317line25>
> >
> >     Is this one copy per command? Agent supports parallel execution of commands. If this is per command can we add the task id to it?
> 
> Andrew Onischuk wrote:
>     it's just a resource of Python script no any parallerity is implemented here.

If there are two start commands from two different components calling HdfsResource then do they share the same file name (/var/lib/ambari-agent/data/hdfs_resources.json)?


- Sumit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/#review83073
-----------------------------------------------------------


On May 8, 2015, 8:55 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33996/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 8:55 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11034
>     https://issues.apache.org/jira/browse/AMBARI-11034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> -
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml a08e81c 
>   ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
>   ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
>   ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
>   ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
>   ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
>   ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
>   ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
>   ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py f1b8ae5 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py aec8e23 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 82a6351 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 47ce98a 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 6909cd7 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py 93c8c71 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 4130472 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 7f17a26 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ee454b6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
>   contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33996/diff/
> 
> 
> Testing
> -------
> 
> tested HA + non-secure/secure - 2.3 stack
> tested non-secure/secure - 2.2 stack
> tested deploy - stack 2.0
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Andrew Onischuk <ao...@hortonworks.com>.

> On May 8, 2015, 8:46 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py, line 78
> > <https://reviews.apache.org/r/33996/diff/1/?file=953323#file953323line78>
> >
> >     Why tserver got removed?

due to role_command_order master always starts first to need to hdfs create dirs both times.


> On May 8, 2015, 8:46 p.m., Sumit Mohanty wrote:
> > ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py, line 25
> > <https://reviews.apache.org/r/33996/diff/1/?file=953317#file953317line25>
> >
> >     Is this one copy per command? Agent supports parallel execution of commands. If this is per command can we add the task id to it?

it's just a resource of Python script no any parallerity is implemented here.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/#review83073
-----------------------------------------------------------


On May 8, 2015, 8:43 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33996/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 8:43 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11034
>     https://issues.apache.org/jira/browse/AMBARI-11034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> -
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml a08e81c 
>   ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
>   ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
>   ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
>   ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
>   ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
>   ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
>   ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
>   ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py f1b8ae5 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py aec8e23 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 82a6351 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 47ce98a 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 6909cd7 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py 93c8c71 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 4130472 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 7f17a26 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ee454b6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
>   contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33996/diff/
> 
> 
> Testing
> -------
> 
> tested HA + non-secure/secure - 2.3 stack
> tested non-secure/secure - 2.2 stack
> tested deploy - stack 2.0
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Andrew Onischuk <ao...@hortonworks.com>.

> On May 8, 2015, 8:46 p.m., Sumit Mohanty wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/__init__.py, line 42
> > <https://reviews.apache.org/r/33996/diff/1/?file=953312#file953312line42>
> >
> >     Does Ambaripreupload.py need to change?

yes it does I'm planning to do that in other patch


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/#review83073
-----------------------------------------------------------


On May 8, 2015, 8:43 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33996/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 8:43 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11034
>     https://issues.apache.org/jira/browse/AMBARI-11034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> -
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml a08e81c 
>   ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
>   ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
>   ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
>   ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
>   ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
>   ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
>   ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
>   ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py f1b8ae5 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py aec8e23 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 82a6351 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 47ce98a 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 6909cd7 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py 93c8c71 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 4130472 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 7f17a26 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ee454b6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
>   contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33996/diff/
> 
> 
> Testing
> -------
> 
> tested HA + non-secure/secure - 2.3 stack
> tested non-secure/secure - 2.2 stack
> tested deploy - stack 2.0
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/#review83073
-----------------------------------------------------------



ambari-common/src/main/python/resource_management/libraries/functions/__init__.py
<https://reviews.apache.org/r/33996/#comment133940>

    Does Ambaripreupload.py need to change?



ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py
<https://reviews.apache.org/r/33996/#comment133943>

    Ambari Common



ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py
<https://reviews.apache.org/r/33996/#comment133944>

    Is this one copy per command? Agent supports parallel execution of commands. If this is per command can we add the task id to it?



ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py
<https://reviews.apache.org/r/33996/#comment133948>

    Why tserver got removed?


- Sumit Mohanty


On May 8, 2015, 8:43 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33996/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 8:43 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11034
>     https://issues.apache.org/jira/browse/AMBARI-11034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> -
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml a08e81c 
>   ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
>   ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
>   ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
>   ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
>   ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
>   ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
>   ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
>   ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py f1b8ae5 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py aec8e23 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 82a6351 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 47ce98a 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 6909cd7 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py 93c8c71 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 4130472 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 7f17a26 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ee454b6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
>   contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33996/diff/
> 
> 
> Testing
> -------
> 
> tested HA + non-secure/secure - 2.3 stack
> tested non-secure/secure - 2.2 stack
> tested deploy - stack 2.0
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/
-----------------------------------------------------------

(Updated May 8, 2015, 8:43 p.m.)


Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-11034
    https://issues.apache.org/jira/browse/AMBARI-11034


Repository: ambari


Description
-------

-


Diffs (updated)
-----

  ambari-agent/pom.xml a08e81c 
  ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
  ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
  ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
  ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
  ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
  ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
  ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
  ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
  ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
  ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
  ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
  ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
  ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
  ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
  ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
  ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py f1b8ae5 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py aec8e23 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 82a6351 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 47ce98a 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 6909cd7 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py 93c8c71 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 4130472 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 7f17a26 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ee454b6 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
  ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
  ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
  ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
  ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
  ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
  ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
  contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
  contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
  contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
  contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
  contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
  contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 

Diff: https://reviews.apache.org/r/33996/diff/


Testing
-------

tested HA + non-secure/secure - 2.3 stack
tested non-secure/secure - 2.2 stack
tested deploy - stack 2.0

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Andrew Onischuk <ao...@hortonworks.com>.

> On May 8, 2015, 8:27 p.m., Jaimin Jetly wrote:
> > ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py, lines 91-95
> > <https://reviews.apache.org/r/33996/diff/1/?file=953317#file953317line91>
> >
> >     hdfs_principal_name is not declared in this patch. where is the variable decalred ?

It's taken from params.py of services, that's it works now. But i agree if some params.py won't containt that in future we gonna have a problem. I fix that thanks


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/#review83069
-----------------------------------------------------------


On May 8, 2015, 8:01 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33996/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 8:01 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11034
>     https://issues.apache.org/jira/browse/AMBARI-11034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> -
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml a08e81c 
>   ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
>   ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
>   ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
>   ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
>   ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
>   ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
>   ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
>   ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 5bb80de 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 59ebb6c1 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py d8d99d5 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 5e0096f 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 5875284 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py c4fb033 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py f430743 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 5db3422 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ae736de 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
>   contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33996/diff/
> 
> 
> Testing
> -------
> 
> tested HA + non-secure/secure - 2.3 stack
> tested non-secure/secure - 2.2 stack
> tested deploy - stack 2.0
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/#review83069
-----------------------------------------------------------



ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py
<https://reviews.apache.org/r/33996/#comment133935>

    hdfs_principal_name is not declared in this patch. where is the variable decalred ?


- Jaimin Jetly


On May 8, 2015, 8:01 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33996/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 8:01 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11034
>     https://issues.apache.org/jira/browse/AMBARI-11034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> -
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml a08e81c 
>   ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
>   ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
>   ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
>   ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
>   ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
>   ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
>   ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
>   ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 5bb80de 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 59ebb6c1 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py d8d99d5 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 5e0096f 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 5875284 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py c4fb033 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py f430743 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 5db3422 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ae736de 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
>   contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33996/diff/
> 
> 
> Testing
> -------
> 
> tested HA + non-secure/secure - 2.3 stack
> tested non-secure/secure - 2.2 stack
> tested deploy - stack 2.0
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/#review83066
-----------------------------------------------------------

Ship it!


We can check it in as it touches a lot of files. I will continue to review it. After checkin, we should monitor system tests to ensure that they are behaving properly.

- Sumit Mohanty


On May 8, 2015, 8:01 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33996/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 8:01 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11034
>     https://issues.apache.org/jira/browse/AMBARI-11034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> -
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml a08e81c 
>   ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
>   ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
>   ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
>   ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
>   ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
>   ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
>   ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
>   ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
>   ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 5bb80de 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 59ebb6c1 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py d8d99d5 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 5e0096f 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 5875284 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py c4fb033 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py f430743 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 5db3422 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ae736de 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
>   contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
>   contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
>   contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33996/diff/
> 
> 
> Testing
> -------
> 
> tested HA + non-secure/secure - 2.3 stack
> tested non-secure/secure - 2.2 stack
> tested deploy - stack 2.0
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/
-----------------------------------------------------------

(Updated May 8, 2015, 8:01 p.m.)


Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-11034
    https://issues.apache.org/jira/browse/AMBARI-11034


Repository: ambari


Description
-------

-


Diffs
-----

  ambari-agent/pom.xml a08e81c 
  ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
  ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
  ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
  ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
  ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
  ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
  ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
  ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
  ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
  ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
  ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
  ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
  ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
  ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
  ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
  ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 5bb80de 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 59ebb6c1 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py d8d99d5 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 5e0096f 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 5875284 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py c4fb033 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py f430743 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 5db3422 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ae736de 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
  ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
  ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
  ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
  ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
  ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
  ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
  contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
  contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
  contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
  contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
  contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
  contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 

Diff: https://reviews.apache.org/r/33996/diff/


Testing (updated)
-------

tested HA + non-secure/secure - 2.3 stack
tested non-secure/secure - 2.2 stack
tested deploy - stack 2.0

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 33996: Implement HdfsResouces and it's usage

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/
-----------------------------------------------------------

(Updated May 8, 2015, 8 p.m.)


Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-11034
    https://issues.apache.org/jira/browse/AMBARI-11034


Repository: ambari


Description (updated)
-------

-


Diffs
-----

  ambari-agent/pom.xml a08e81c 
  ambari-agent/src/test/python/resource_management/TestContentSources.py d35ec9a 
  ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py 1ec1858 
  ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py bb91159 
  ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 6b94481 
  ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py a7eaae9 
  ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 
  ambari-common/src/main/python/resource_management/libraries/functions/__init__.py e06d246 
  ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
  ambari-common/src/main/python/resource_management/libraries/providers/__init__.py 34b10a9 
  ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py bd9805c 
  ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py 9fa2de7 
  ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py PRE-CREATION 
  ambari-common/src/main/python/resource_management/libraries/resources/__init__.py 596c2e2 
  ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py 42050a3 
  ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py 7888cd8 
  ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py PRE-CREATION 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 9f8653b 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py e974573 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 88d83d3 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 5bb80de 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py cd9f8f9 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 7e516b8 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py ed9098c 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 27ced1d 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 9a35a24 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 59ebb6c1 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py a60ebad 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar PRE-CREATION 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py a615c27 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py e36019e 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py ad5ef89 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3feff67 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py d8d99d5 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dd319b0 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh d16848d 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bfd4e74 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d86de3d 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bd6f70e 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 733ab0a 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9b59f30 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 5e0096f 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py f46c41f 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh 32211c4 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh PRE-CREATION 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 6adf2ac 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c3d9c78 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 5875284 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py d589452 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py c4fb033 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 9de30ed 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py 0206415 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py f430743 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 80d6bbc 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 26a403d 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 5aadd99 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 5db3422 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py 6786eba 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py f4dceb5 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py a18ca72 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py 6d17aca 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py ae736de 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 9d5fb97 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 81da809 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 583e6e9 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py b56d15a 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py ea8d9d4 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 3c098b6 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 7bbd0a9 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 3fa1c9c 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d0a71c0 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py bcd5ad9 
  ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py efec6f7 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 26fab63 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py 01073df 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f40beac 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py d4017f7 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py cd6f693 
  ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd 
  ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py dd3f4f2 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 60d7924 
  ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 
  ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 
  ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 0d943c4 
  contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION 
  contrib/fast-hdfs-resource/pom.xml PRE-CREATION 
  contrib/fast-hdfs-resource/resources/example.json PRE-CREATION 
  contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION 
  contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java PRE-CREATION 
  contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java PRE-CREATION 

Diff: https://reviews.apache.org/r/33996/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk