You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/12 13:13:14 UTC
[GitHub] [skywalking-python] Superskyyy opened a new pull request #154: Enable Kafka log reporting
Superskyyy opened a new pull request #154:
URL: https://github.com/apache/skywalking-python/pull/154
- Supports Kafka log reporter
- Fixes a small bug in log reporter with empty layout
Tested working using single node Kafka in docker.
<!-- Uncomment the following checklist WHEN AND ONLY WHEN you're adding a new plugin -->
<!--
- [ ] Add a test case for the new plugin
- [ ] Add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L415)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
- [ ] Rebuild the `requirements.txt` by running `tools/env/build_requirements_(linux|windows).sh`
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Humbertzhang commented on a change in pull request #154: Enable Kafka log reporting
Posted by GitBox <gi...@apache.org>.
Humbertzhang commented on a change in pull request #154:
URL: https://github.com/apache/skywalking-python/pull/154#discussion_r687766637
##########
File path: skywalking/config.py
##########
@@ -72,8 +73,8 @@
os.getenv('SW_AGENT_LOG_REPORTER_ACTIVE') == 'True' else False # type: bool
log_reporter_max_buffer_size = int(os.getenv('SW_AGENT_LOG_REPORTER_BUFFER_SIZE') or '10000') # type: int
log_reporter_level = os.getenv('SW_AGENT_LOG_REPORTER_LEVEL') or 'WARNING' # type: str
-log_reporter_ignore_filter = True if os.getenv('SW_AGENT_LOG_IGNORE_FILTER') and \
- os.getenv('SW_AGENT_LOG_REPORTER_FORMATTED') == 'True' else False # type: bool
+log_reporter_ignore_filter = True if os.getenv('SW_AGENT_LOG_REPORTER_IGNORE_FILTER') and \
Review comment:
Should change the EnvVars document as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on a change in pull request #154: Enable Kafka log reporting
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on a change in pull request #154:
URL: https://github.com/apache/skywalking-python/pull/154#discussion_r687829233
##########
File path: skywalking/config.py
##########
@@ -72,8 +73,8 @@
os.getenv('SW_AGENT_LOG_REPORTER_ACTIVE') == 'True' else False # type: bool
log_reporter_max_buffer_size = int(os.getenv('SW_AGENT_LOG_REPORTER_BUFFER_SIZE') or '10000') # type: int
log_reporter_level = os.getenv('SW_AGENT_LOG_REPORTER_LEVEL') or 'WARNING' # type: str
-log_reporter_ignore_filter = True if os.getenv('SW_AGENT_LOG_IGNORE_FILTER') and \
- os.getenv('SW_AGENT_LOG_REPORTER_FORMATTED') == 'True' else False # type: bool
+log_reporter_ignore_filter = True if os.getenv('SW_AGENT_LOG_REPORTER_IGNORE_FILTER') and \
Review comment:
Fixed. Thanks for pointing out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 merged pull request #154: Enable Kafka log reporting
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #154:
URL: https://github.com/apache/skywalking-python/pull/154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org