You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/01/10 02:49:22 UTC
Re: Review Request 54762: Introduced an `os::pipe` abstraction to
stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54762/
-----------------------------------------------------------
(Updated Jan. 9, 2017, 6:49 p.m.)
Review request for mesos, Daniel Pravat and Joris Van Remoortere.
Changes
-------
Rebased.
Repository: mesos
Description
-------
Introduced an `os::pipe` abstraction to stout.
Diffs (updated)
-----
3rdparty/stout/include/Makefile.am 53d04a9b6c4a0d8b35d3c84ef24d619fdb8a2c82
3rdparty/stout/include/stout/os.hpp ed6fec3ac1c1f9dfb0585178401f4b552822a0a1
3rdparty/stout/include/stout/os/pipe.hpp PRE-CREATION
3rdparty/stout/include/stout/os/posix/pipe.hpp PRE-CREATION
3rdparty/stout/include/stout/os/windows/pipe.hpp PRE-CREATION
3rdparty/stout/include/stout/posix/os.hpp 397c2d6b06ddb607d254eae8258da5151c5f57e0
3rdparty/stout/include/stout/windows/os.hpp 5cd92545a49648e39e8eb7cf131895e9cfc97902
Diff: https://reviews.apache.org/r/54762/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 54762: Introduced an `os::pipe` abstraction to
stout.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54762/#review164279
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/stout/include/Makefile.am (line 129)
<https://reviews.apache.org/r/54762/#comment235953>
Probably want to line these slashes up?
3rdparty/stout/include/stout/os/windows/pipe.hpp (line 43)
<https://reviews.apache.org/r/54762/#comment235954>
This seems like it should be using `WindowsError` instead? `ErrnoError` is usually only for CRT functions, while `WindowsError` also captures win32 error codes.
- Alex Clemmer
On Feb. 5, 2017, 1:38 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54762/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2017, 1:38 a.m.)
>
>
> Review request for mesos, Daniel Pravat and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Introduced an `os::pipe` abstraction to stout.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/Makefile.am 53d04a9b6c4a0d8b35d3c84ef24d619fdb8a2c82
> 3rdparty/stout/include/stout/os.hpp ed6fec3ac1c1f9dfb0585178401f4b552822a0a1
> 3rdparty/stout/include/stout/os/pipe.hpp PRE-CREATION
> 3rdparty/stout/include/stout/os/posix/pipe.hpp PRE-CREATION
> 3rdparty/stout/include/stout/os/windows/pipe.hpp PRE-CREATION
> 3rdparty/stout/include/stout/posix/os.hpp 68df2ef5cda9416d2d3bfa94f05ac04bf35d663f
> 3rdparty/stout/include/stout/windows/os.hpp c123772ab018d327b02dacfb314b835b9f373cfc
>
> Diff: https://reviews.apache.org/r/54762/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 54762: Introduced an `os::pipe` abstraction to
stout.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54762/
-----------------------------------------------------------
(Updated Feb. 5, 2017, 6:27 p.m.)
Review request for mesos, Daniel Pravat and Joris Van Remoortere.
Changes
-------
Addressed Alex's comments.
Repository: mesos
Description
-------
Introduced an `os::pipe` abstraction to stout.
Diffs (updated)
-----
3rdparty/stout/include/Makefile.am 53d04a9b6c4a0d8b35d3c84ef24d619fdb8a2c82
3rdparty/stout/include/stout/os.hpp ed6fec3ac1c1f9dfb0585178401f4b552822a0a1
3rdparty/stout/include/stout/os/pipe.hpp PRE-CREATION
3rdparty/stout/include/stout/os/posix/pipe.hpp PRE-CREATION
3rdparty/stout/include/stout/os/windows/pipe.hpp PRE-CREATION
3rdparty/stout/include/stout/posix/os.hpp 68df2ef5cda9416d2d3bfa94f05ac04bf35d663f
3rdparty/stout/include/stout/windows/os.hpp c123772ab018d327b02dacfb314b835b9f373cfc
Diff: https://reviews.apache.org/r/54762/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 54762: Introduced an `os::pipe` abstraction to
stout.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54762/
-----------------------------------------------------------
(Updated Feb. 4, 2017, 5:38 p.m.)
Review request for mesos, Daniel Pravat and Joris Van Remoortere.
Changes
-------
Rebased.
Repository: mesos
Description
-------
Introduced an `os::pipe` abstraction to stout.
Diffs (updated)
-----
3rdparty/stout/include/Makefile.am 53d04a9b6c4a0d8b35d3c84ef24d619fdb8a2c82
3rdparty/stout/include/stout/os.hpp ed6fec3ac1c1f9dfb0585178401f4b552822a0a1
3rdparty/stout/include/stout/os/pipe.hpp PRE-CREATION
3rdparty/stout/include/stout/os/posix/pipe.hpp PRE-CREATION
3rdparty/stout/include/stout/os/windows/pipe.hpp PRE-CREATION
3rdparty/stout/include/stout/posix/os.hpp 68df2ef5cda9416d2d3bfa94f05ac04bf35d663f
3rdparty/stout/include/stout/windows/os.hpp c123772ab018d327b02dacfb314b835b9f373cfc
Diff: https://reviews.apache.org/r/54762/diff/
Testing
-------
Thanks,
Michael Park