You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "vustef (via GitHub)" <gi...@apache.org> on 2025/10/27 13:05:23 UTC
[PR] General support for metadata columns + implementation for `_pos` [iceberg-rust]
vustef opened a new pull request, #1791:
URL: https://github.com/apache/iceberg-rust/pull/1791
## Which issue does this PR close?
https://github.com/apache/iceberg-rust/issues/1765
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Closes #.
## What changes are included in this PR?
<!--
Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates.
-->
## Are these changes tested?
<!--
Specify what test covers (unit test, integration test, etc.).
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] General support for metadata columns + implementation for `_pos` [iceberg-rust]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1791:
URL: https://github.com/apache/iceberg-rust/pull/1791#issuecomment-4008677047
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] General support for metadata columns + implementation for `_pos` [iceberg-rust]
Posted by "vustef (via GitHub)" <gi...@apache.org>.
vustef commented on PR #1791:
URL: https://github.com/apache/iceberg-rust/pull/1791#issuecomment-3557578188
Blueprint of how we're thinking about this: https://github.com/RelationalAI/iceberg-rust/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] General support for metadata columns + implementation for `_pos` [iceberg-rust]
Posted by "vustef (via GitHub)" <gi...@apache.org>.
vustef commented on code in PR #1791:
URL: https://github.com/apache/iceberg-rust/pull/1791#discussion_r2465614941
##########
crates/iceberg/src/scan/mod.rs:
##########
@@ -183,6 +186,14 @@ impl<'a> TableScanBuilder<'a> {
self
}
+ /// Sets the metadata columns to include in the result
+ ///
+ /// Metadata columns are virtual columns that provide metadata about the rows,
+ /// such as file paths or row positions. These come from https://iceberg.apache.org/spec/#identifier-field-ids
+ pub fn with_metadata_columns(mut self, metadata_columns: Vec<String>) -> Self {
Review Comment:
Need some validation here, for allowed column names. Or type safety, to pick columns from enum (possibly preventing duplication?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] General support for metadata columns + implementation for `_pos` [iceberg-rust]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #1791: General support for metadata columns + implementation for `_pos`
URL: https://github.com/apache/iceberg-rust/pull/1791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org