[GitHub] [pulsar] eolivelli commented on a change in pull request #11893: Admin cli support terminate a partitioned topic

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #11893:
URL: https://github.com/apache/pulsar/pull/11893#discussion_r702711938



##########
File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java
##########
@@ -709,6 +709,26 @@ default void delete(String topic, boolean force) throws PulsarAdminException {
      */
     CompletableFuture<MessageId> terminateTopicAsync(String topic);
 
+    /**
+     * Terminate the partitioned topic and prevent any more messages being published on it.
+     * <p/>
+     *
+     * @param topic
+     *            topic name
+     * @return the message id of the last message that was published in the each partition of topic
+     */
+    List<MessageId> terminatePartitionedTopic(String topic) throws PulsarAdminException;

Review comment:
       Is it better to return a Map?
   Because it is hard to understand the contents of the list, especially in case of null values




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org