[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10278: Don't log the entire task spec

[GitBox <gi...@apache.org>]

abhishekagarwal87 commented on a change in pull request #10278:
URL: https://github.com/apache/druid/pull/10278#discussion_r471011332



##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractTask.java
##########
@@ -175,23 +162,6 @@ public String toString()
            '}';
   }
 
-  /**
-   * Start helper methods
-   *
-   * @param objects objects to join
-   *
-   * @return string of joined objects
-   */
-  static String joinId(List<Object> objects)
-  {
-    return ID_JOINER.join(objects);

Review comment:
       nit: ID_JOINER field can be removed from the class. 

##########
File path: server/src/main/java/org/apache/druid/client/indexing/IndexingServiceClient.java
##########
@@ -31,11 +31,27 @@
 
 public interface IndexingServiceClient
 {
-  void killUnusedSegments(String dataSource, Interval interval);
+  default void killUnusedSegments(String dataSource, Interval interval)
+  {
+    killUnusedSegments("", dataSource, interval);

Review comment:
       naive question: can the IndexingServiceClient used outside druid code? If not, a default method may not be required. If yes, passing null instead of an empty string will be closer to past behavior. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org