You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/03 20:31:34 UTC

[GitHub] [arrow-datafusion] james727 opened a new pull request #1519: Fix single_distinct_to_groupby for arbitrary expressions

james727 opened a new pull request #1519:
URL: https://github.com/apache/arrow-datafusion/pull/1519


   # Which issue does this PR close?
   This addresses the bug in `single_distinct_to_groupby.rs` described in https://github.com/apache/arrow-datafusion/issues/1512
   
   Right now the `SingleDistinctToGroupBy` optimizer rule only works on literal or column expressions. For more complex expressions (like binary operators), the optimization breaks due to searching for the right/left operands in the derived schema rather than the input schema. This patch modifies the logic to search in the input schema instead.
   
   # What changes are included in this PR?
   This just includes the logic fix and some tests that would have broken before.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #1519: Fix single_distinct_to_groupby for arbitrary expressions

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1519:
URL: https://github.com/apache/arrow-datafusion/pull/1519#issuecomment-1005636331


   Thanks again @james727 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #1519: Fix single_distinct_to_groupby for arbitrary expressions

Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1519:
URL: https://github.com/apache/arrow-datafusion/pull/1519


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #1519: Fix single_distinct_to_groupby for arbitrary expressions

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1519:
URL: https://github.com/apache/arrow-datafusion/pull/1519#issuecomment-1005199251


   Thanks @james727  -- I'll take a look at this tomorrow!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] james727 commented on pull request #1519: Fix single_distinct_to_groupby for arbitrary expressions

Posted by GitBox <gi...@apache.org>.
james727 commented on pull request #1519:
URL: https://github.com/apache/arrow-datafusion/pull/1519#issuecomment-1005797032


   No problem, glad it's useful. Appreciate the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org