[GitHub] [arrow] ianmcook commented on a change in pull request #10615: ARROW-12967: [R] Add bindings for pmin() and pmax() #10497 #10613

[GitBox <gi...@apache.org>]

ianmcook commented on a change in pull request #10615:
URL: https://github.com/apache/arrow/pull/10615#discussion_r660872194



##########
File path: r/src/compute.cpp
##########
@@ -180,6 +180,15 @@ std::shared_ptr<arrow::compute::FunctionOptions> make_compute_options(
     return out;
   }
 
+  if (func_name == "element_wise_min" || func_name == "element_wise_max") {
+    using Options = arrow::compute::ElementWiseAggregateOptions;
+    bool skip_nulls = false;

Review comment:
       As mentioned here... https://github.com/apache/arrow/blob/57ecc73e6153fea04e0ac0d13792ba0abb0dd779/cpp/src/arrow/compute/kernels/scalar_compare.cc#L472... `skip_nulls = true` is the default, so let's make it the default here too:
   ```suggestion
       bool skip_nulls = true;
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org