You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2021/09/09 13:27:35 UTC

[GitHub] [tomcat] rmaucher commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

rmaucher commented on pull request #428:
URL: https://github.com/apache/tomcat/pull/428#issuecomment-916091098


   Looking back at this since I thin I have time to merge it. Shouldn't some of the changes be dropped and focused only on the realms that show a benefit ?
   - JNDIRealm: Very useful, that's likely the whole point of this new feature.
   - DataSourceRealm: This does something useful but less so and it is complex.
   - MemoryRealm: This adds some complexity for a fixed list of attributes which do not seem that useful.
   - UserDatabaseRealm: Same.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org