You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/18 16:24:32 UTC
[GitHub] [pulsar] cbornet opened a new pull request, #16129: [improve][function] Support Record as WindowFunction output type
cbornet opened a new pull request, #16129:
URL: https://github.com/apache/pulsar/pull/16129
### Motivation
Same as https://github.com/apache/pulsar/pull/16041 for WindowFunction
### Modifications
Detect and unwrap Record type in getFunctionTypes if the class is a WindowFunction
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
Run `FunctionCommonTest::testGetFunctionTypes`
### Does this pull request potentially affect one of the following parts:
no
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [x] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on pull request #16129: [improve][function] Support Record as WindowFunction output type
Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #16129:
URL: https://github.com/apache/pulsar/pull/16129#issuecomment-1330190211
Hi @cbornet This improvement is introduced in the 2.11 release. Did you have any plans for the doc update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on pull request #16129: [improve][function] Support Record as WindowFunction output type
Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #16129:
URL: https://github.com/apache/pulsar/pull/16129#issuecomment-1330673819
@momo-jun I opened https://github.com/apache/pulsar/issues/18674 to add doc on how to write a window function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi merged pull request #16129: [improve][function] Support Record as WindowFunction output type
Posted by GitBox <gi...@apache.org>.
nicoloboschi merged PR #16129:
URL: https://github.com/apache/pulsar/pull/16129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on pull request #16129: [improve][function] Support Record as WindowFunction output type
Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #16129:
URL: https://github.com/apache/pulsar/pull/16129#issuecomment-1330507956
> There doesn't seem to be a place where writing a Window function is documented so I don't know where to add this.
If it's a developer's task, you can consider adding it to the `How to develop` topic.
More relevant topics for X-ref linking:
* [Window function concept](https://pulsar.apache.org/docs/next/functions-concepts#window-function)
* [Start a window function](https://pulsar.apache.org/docs/next/functions-quickstart#start-window-functions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on pull request #16129: [improve][function] Support Record as WindowFunction output type
Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #16129:
URL: https://github.com/apache/pulsar/pull/16129#issuecomment-1330422334
There doesn't seem to be a place where writing a Window function is documented so I don't know where to add this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org