You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/06/12 14:51:12 UTC
Re: Review Request 67487: Used `$PYTHON` in configure.ac and
Makefile.am.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67487/
-----------------------------------------------------------
(Updated June 12, 2018, 2:51 p.m.)
Review request for mesos, Eric Chung and Kevin Klues.
Changes
-------
Switched from `$PYTHON_2`/`$PYTHON_2_VERSION` to `$PYTHON`/`$PYTHON_VERSION` (as before).
Summary (updated)
-----------------
Used `$PYTHON` in configure.ac and Makefile.am.
Bugs: MESOS-8955
https://issues.apache.org/jira/browse/MESOS-8955
Repository: mesos
Description (updated)
-------
This ensures that we use Python 2 even if the Python
intepreter under the command `python` is Python 3.
Diffs (updated)
-----
configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123
src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71
Diff: https://reviews.apache.org/r/67487/diff/2/
Changes: https://reviews.apache.org/r/67487/diff/1-2/
Testing
-------
In `build`:
```
$ ../configure --disable-java --enable-new-cli
$ GTEST_FILTER="" nice make -j16 check
```
Thanks,
Armand Grillet
Re: Review Request 67487: Used `$PYTHON` in configure.ac and
Makefile.am.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67487/#review205724
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On June 12, 2018, 2:51 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67487/
> -----------------------------------------------------------
>
> (Updated June 12, 2018, 2:51 p.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This ensures that we use Python 2 even if the Python
> intepreter under the command `python` is Python 3.
>
>
> Diffs
> -----
>
> configure.ac 8b8064aca7ae39e16dda40828b5a087b14b54a65
> src/Makefile.am de808205f59a485d758d1baf9d990bc631eb8c5c
>
>
> Diff: https://reviews.apache.org/r/67487/diff/7/
>
>
> Testing
> -------
>
> In `build`:
> ```
> $ ../configure --disable-java --enable-new-cli
> $ GTEST_FILTER="" nice make -j16 check
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 67487: Used `$PYTHON` in configure.ac and
Makefile.am.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67487/#review204690
-----------------------------------------------------------
src/Makefile.am
Lines 1804-1816 (original), 1804-1816 (patched)
<https://reviews.apache.org/r/67487/#comment287302>
Can you set PYTHON here so we know which python version we are building the virtualenv with?
- Kevin Klues
On June 12, 2018, 2:51 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67487/
> -----------------------------------------------------------
>
> (Updated June 12, 2018, 2:51 p.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This ensures that we use Python 2 even if the Python
> intepreter under the command `python` is Python 3.
>
>
> Diffs
> -----
>
> configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123
> src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71
>
>
> Diff: https://reviews.apache.org/r/67487/diff/3/
>
>
> Testing
> -------
>
> In `build`:
> ```
> $ ../configure --disable-java --enable-new-cli
> $ GTEST_FILTER="" nice make -j16 check
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 67487: Used `$PYTHON` in configure.ac and
Makefile.am.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67487/#review204606
-----------------------------------------------------------
PASS: Mesos patch 67487 was successfully built and tested.
Reviews applied: `['67411', '67412', '67413', '67487']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67487
- Mesos Reviewbot Windows
On June 12, 2018, 7:51 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67487/
> -----------------------------------------------------------
>
> (Updated June 12, 2018, 7:51 a.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This ensures that we use Python 2 even if the Python
> intepreter under the command `python` is Python 3.
>
>
> Diffs
> -----
>
> configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123
> src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71
>
>
> Diff: https://reviews.apache.org/r/67487/diff/3/
>
>
> Testing
> -------
>
> In `build`:
> ```
> $ ../configure --disable-java --enable-new-cli
> $ GTEST_FILTER="" nice make -j16 check
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>