[GitHub] [maven-verifier] michael-o commented on a diff in pull request #49: [MSHARED-1128] Update documentation with new execute method

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #49:
URL: https://github.com/apache/maven-verifier/pull/49#discussion_r975705291


##########
src/site/markdown/getting-started.md:
##########
@@ -129,17 +129,24 @@ For the Context Class Loader case this would mean the following dependencies are
 
 ## Run
 
-Calling `executeGoals` runs Maven with the given goals or phases and optionally some additional environment variables. It throws a `VerificationException` in case the execution is not successful (e.g. binary not found or exit code > 0). It is either using a forked JVM or is executed in the same JVM depending on the configuration.
+Calling `execute` runs Maven with the given Verifier configuration like, cli arguments, environment variables. 
+We must provide at lease one cli argument for executing.

Review Comment:
   Do we really need that? What if `/project/build/defaultGoal` is set?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org