You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "YayoiNanoka (via GitHub)" <gi...@apache.org> on 2026/10/17 07:33:46 UTC

[PR] fix(test): publish shell owner readiness markers atomically [maka]

YayoiNanoka opened a new pull request, #6135:
URL: https://github.com/apache/maka/pull/6135

   ## Summary
   
   The shell owner-death tests can read an empty readiness marker between file creation and the first JSON write, causing a JSON parse failure before they exercise owner death. Write the complete marker to a temporary file and rename it into place in both test fixtures. The existing process termination and delayed-write assertions remain unchanged; production behavior is unchanged.
   
   Extracted from #6091 so the unrelated CI reliability fix can be reviewed independently.
   
   ## Verification
   
   - Built `@maka/core`, `@maka/storage`, and `@maka/runtime` successfully.
   - Passed the complete `shell-owner-death.test.js` suite three consecutive times on macOS: 6 tests per run, 18 executions, no failures or skips.
   - Passed runtime typecheck and lint/format checks for the changed file.
   - Passed the staged ASF header, protocol epoch, and whitespace checks.
   - Windows execution is left to CI. The original race is timing-dependent; this change does not add a deterministic fault-injection test.
   
   ## AI use
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: OpenAI Codex extracted the existing fixture fix, ran validation, and prepared this PR. The commit retains its `Generated-by: OpenAI Codex` trailer.
   
   ## Checklist
   
   - [ ] Tests cover the change and fail without it
   - [x] Lint, format, typecheck and the affected suites pass locally
   
   The existing owner-death suite covers both marker producers; reproducing the pre-fix empty-file race depends on scheduling.
   
   Does this PR entail a change in behavior?
   
   - [ ] Yes — described under Summary above
   - [x] No
   
   <details>
   <summary>点击展开中文</summary>
   
   Shell owner-death 测试的就绪标记先创建文件、再写入 JSON，轮询可能读到空文件并提前解析失败。此修复让两个测试 fixture 先把完整 JSON 写入临时文件，再通过重命名发布标记，保留原有的进程回收和延迟写入断言，不改变生产代码。
   
   该修复从 #6091 拆出，单独审查。
   
   验证：core、storage、runtime 构建成功；完整 owner-death 测试连续三轮通过，每轮 6 项，共 18 次执行，无失败或跳过；runtime 类型检查、变更文件 lint/格式检查，以及提交时的许可证、协议版本和空白检查通过。Windows 由 CI 验证。原竞态依赖调度时机，本次没有增加确定性的故障注入测试。
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org

Re: [PR] fix(test): publish shell owner readiness markers atomically [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on PR #6135:
URL: https://github.com/apache/maka/pull/6135#issuecomment-6256917381

   Thanks for the contribution and for addressing the review feedback. Merging now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org

Re: [PR] fix(test): publish shell owner readiness markers atomically [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #6135:
URL: https://github.com/apache/maka/pull/6135


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org