[jira] [Commented] (THRIFT-3027) Go compiler does not ensure common initialisms have consistent case

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350376#comment-14350376 ] 

ASF GitHub Bot commented on THRIFT-3027:
----------------------------------------

GitHub user Magrath opened a pull request:

    https://github.com/apache/thrift/pull/394

    THRIFT-3027 Ensure common initialisms in generated Go code have consistent case

    In Go, as per https://github.com/golang/go/wiki/CodeReviewComments#initialisms, words in names that are initialisms or acronyms should have a consistent case.
    
    https://issues.apache.org/jira/browse/THRIFT-3027

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Magrath/thrift THRIFT-3027

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/394.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #394
    
----
commit c3f9c8a8d21e8c921be7aa34f3379bc4dd7b0732
Author: Paul Magrath <pa...@swiftkey.com>
Date:   2015-03-06T14:26:58Z

    THRIFT-3027 Ensure common initialisms in generated Go code have consistent case

----


> Go compiler does not ensure common initialisms have consistent case
> -------------------------------------------------------------------
>
>                 Key: THRIFT-3027
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3027
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Go - Compiler
>    Affects Versions: 0.9.2
>            Reporter: Paul Magrath
>            Priority: Minor
>
> In Go, as per https://github.com/golang/go/wiki/CodeReviewComments#initialisms, words in names that are initialisms or acronyms should have a consistent case. 
> For example, if you have a struct like:
> {code}
> struct InitialismsTest {
>     1: string user_id,
>     2: string server_url,
> }
> {code}
> One would expect it to compile to:
> {code}
> type InitialismsTest struct {
> 	UserID    string `thrift:"user_id,1" json:"user_id"`
> 	ServerURL string `thrift:"server_url,2" json:"server_url"`
> }
> {code}
> Rather than:-
> {code}
> type InitialismsTest struct {
> 	UserId    string `thrift:"user_id,1" json:"user_id"`
> 	ServerUrl string `thrift:"server_url,2" json:"server_url"`
> }
> {code}
> It would be pretty difficult to handle all cases of initialisms in the Go compiler of course, but there is a set of common initialisms that have been identified by the authors of Golint and could be handled relatively easily:- https://github.com/golang/lint/blob/master/lint.go#L692 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)