You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/25 02:29:58 UTC

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1097: feat: "upstream" i18n

liuxiran commented on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-751151198


   LGTM except for name style of the i18n key, it would be better to use a unified, meaningful and readable way. 
   
   maybe #331 is a good reference ^^


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org