You are viewing a plain text version of this content. The canonical link for it is here.
Posted to batik-dev@xmlgraphics.apache.org by Cameron McCormack <ca...@mcc.id.au> on 2007/01/22 09:40:17 UTC
Ready for release?
Hi everyone.
I’ve finished all the work I wanted to get done on Batik before the
release. I was planning on writing some regard tests for the animation
support, but I’m not sure I can be bothered at the moment and I don’t
want to hold the release back. I did run all of the animation tests
from the SVG WG’s latest test suite, and nearly all pass (just some
missing hyperlinking functionality).
Due to some rendering problems using the XML Graphics Commons classes, I
propose we postpone Batik’s migration to using them until after the
release.
Thomas and Dieter, could you run regard on your systems to see that
there’s nothing that’s been overlooked? I will do so also. I don’t
think there are any more low-hanging fruits in Bugzilla, but have a skim
through them in case I missed something.
Given the number of changes since the last release, would it be wise to
make a release candidate that people can test, before the proper 1.7
release? If so, how long for?
Thanks,
Cameron
--
Cameron McCormack, http://mcc.id.au/
xmpp:heycam@jabber.org ▪ ICQ 26955922 ▪ MSN cam@mcc.id.au
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by Dieter von Holten <in...@dvholten.de>.
hello,
yes, i ran regard and it looked quite good: even the sub- and superscript
texts are back in their place.
The idea with a release candidate is a good one, i propose 2-4 weeks.
greetings
dieter
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by Cameron McCormack <ca...@mcc.id.au>.
Cameron McCormack:
> I’ve finished all the work I wanted to get done on Batik before the
> release.
Oh I forgot to mention that a bug in Rhino needs to be fixed first, so
that the script debugger works properly without needing to grant undue
permissions to js.jar, but that shouldn’t take long to fix.
--
Cameron McCormack, http://mcc.id.au/
xmpp:heycam@jabber.org ▪ ICQ 26955922 ▪ MSN cam@mcc.id.au
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
On 22.01.2007 12:31:57 Cameron McCormack wrote:
> Hi Jeremias.
>
> Jeremias Maerki:
> > I've taken a glance at all the legal information that is around. Here
> > are my findings:
> >
> > - NOTICE should be updated to conform to http://www.apache.org/legal/src-headers.html
> > The second paragraph should be ("at" instead of "by"):
> > This product includes software developed at
> > The Apache Software Foundation (http://www.apache.org/).
>
> Is the s/at/by/ the only change needed to conform? Were the other
> paragraphs I put in the file OK?
Yes, I believe so.
> > - The license for pdf-transcoder.jar is still 1.1, but should be 2.0.
>
> Right, ok.
>
> > - I think it would be good to note in the readme for pdf-transcoder.jar
> > that it was derived from the FOP 0.90alpha1 release. This is otherwise
> > not apparent, only when you go checking the SVN log:
> > http://svn.apache.org/viewvc/xmlgraphics/batik/trunk/lib/pdf-transcoder.jar?view=log
>
> Ok.
>
> > - The license info should always indicate the right license version.
> > "Apache License" is not enough. Please check all the readme files in lib.
>
> Checked.
>
> > - xml-stylebook and crimson are ALv1.1, not 2.0 (as implied by pointing
> > to LICENSE in the root directory). Better just list the ALv1.1.
> >
> > - The README for xml-stylebook should point to http://svn.apache.org/viewvc/xml/stylebook/trunk/
>
> Ok. I’ve removed xml-stylebook since it’s not needed any more.
Even better then.
> > Cameron, would it make sense to create a branch for Batik with the goal
> > of finishing the integration of XML Graphics Commons (irrespective of
> > the Batik release)? That way I don't have to redo the adjustments you
> > had to make and therefore I can more easily help you figure out what
> > going wrong. Finally, are the problems apparent in any case or are there
> > only special cases where the problem shows? Which are those? Thanks!
>
> Yeah that’s a good idea, better than leaving it sitting around on my
> hard drive. I’ve committed my current changes to
> …/batik/branches/commons-integration.
>
> If you open samples/mathMetal.svg with Batik trunk and with that branch,
> you will see the colour difference. I think it’s something to do with
> filters, but I haven’t really investigated yet.
Thanks. I'll take a look ASAP.
Jeremias Maerki
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by Cameron McCormack <ca...@mcc.id.au>.
Hi Jeremias.
Jeremias Maerki:
> I've taken a glance at all the legal information that is around. Here
> are my findings:
>
> - NOTICE should be updated to conform to http://www.apache.org/legal/src-headers.html
> The second paragraph should be ("at" instead of "by"):
> This product includes software developed at
> The Apache Software Foundation (http://www.apache.org/).
Is the s/at/by/ the only change needed to conform? Were the other
paragraphs I put in the file OK?
> - The license for pdf-transcoder.jar is still 1.1, but should be 2.0.
Right, ok.
> - I think it would be good to note in the readme for pdf-transcoder.jar
> that it was derived from the FOP 0.90alpha1 release. This is otherwise
> not apparent, only when you go checking the SVN log:
> http://svn.apache.org/viewvc/xmlgraphics/batik/trunk/lib/pdf-transcoder.jar?view=log
Ok.
> - The license info should always indicate the right license version.
> "Apache License" is not enough. Please check all the readme files in lib.
Checked.
> - xml-stylebook and crimson are ALv1.1, not 2.0 (as implied by pointing
> to LICENSE in the root directory). Better just list the ALv1.1.
>
> - The README for xml-stylebook should point to http://svn.apache.org/viewvc/xml/stylebook/trunk/
Ok. I’ve removed xml-stylebook since it’s not needed any more.
> Cameron, would it make sense to create a branch for Batik with the goal
> of finishing the integration of XML Graphics Commons (irrespective of
> the Batik release)? That way I don't have to redo the adjustments you
> had to make and therefore I can more easily help you figure out what
> going wrong. Finally, are the problems apparent in any case or are there
> only special cases where the problem shows? Which are those? Thanks!
Yeah that’s a good idea, better than leaving it sitting around on my
hard drive. I’ve committed my current changes to
…/batik/branches/commons-integration.
If you open samples/mathMetal.svg with Batik trunk and with that branch,
you will see the colour difference. I think it’s something to do with
filters, but I haven’t really investigated yet.
--
Cameron McCormack, http://mcc.id.au/
xmpp:heycam@jabber.org ▪ ICQ 26955922 ▪ MSN cam@mcc.id.au
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
I've taken a glance at all the legal information that is around. Here
are my findings:
- NOTICE should be updated to conform to http://www.apache.org/legal/src-headers.html
The second paragraph should be ("at" instead of "by"):
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
- The license for pdf-transcoder.jar is still 1.1, but should be 2.0.
- I think it would be good to note in the readme for pdf-transcoder.jar
that it was derived from the FOP 0.90alpha1 release. This is otherwise
not apparent, only when you go checking the SVN log:
http://svn.apache.org/viewvc/xmlgraphics/batik/trunk/lib/pdf-transcoder.jar?view=log
- The license info should always indicate the right license version.
"Apache License" is not enough. Please check all the readme files in lib.
- xml-stylebook and crimson are ALv1.1, not 2.0 (as implied by pointing
to LICENSE in the root directory). Better just list the ALv1.1.
- The README for xml-stylebook should point to http://svn.apache.org/viewvc/xml/stylebook/trunk/
-----
Cameron, would it make sense to create a branch for Batik with the goal
of finishing the integration of XML Graphics Commons (irrespective of
the Batik release)? That way I don't have to redo the adjustments you
had to make and therefore I can more easily help you figure out what
going wrong. Finally, are the problems apparent in any case or are there
only special cases where the problem shows? Which are those? Thanks!
On 22.01.2007 09:40:17 Cameron McCormack wrote:
> Hi everyone.
>
> I’ve finished all the work I wanted to get done on Batik before the
> release. I was planning on writing some regard tests for the animation
> support, but I’m not sure I can be bothered at the moment and I don’t
> want to hold the release back. I did run all of the animation tests
> from the SVG WG’s latest test suite, and nearly all pass (just some
> missing hyperlinking functionality).
>
> Due to some rendering problems using the XML Graphics Commons classes, I
> propose we postpone Batik’s migration to using them until after the
> release.
>
> Thomas and Dieter, could you run regard on your systems to see that
> there’s nothing that’s been overlooked? I will do so also. I don’t
> think there are any more low-hanging fruits in Bugzilla, but have a skim
> through them in case I missed something.
>
> Given the number of changes since the last release, would it be wise to
> make a release candidate that people can test, before the proper 1.7
> release? If so, how long for?
>
> Thanks,
>
> Cameron
Jeremias Maerki
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by Cameron McCormack <ca...@mcc.id.au>.
Cameron McCormack:
> The only problem I found was that SVG 1.2 resource documents were being
> held in memory because of the animation engine’s IdleRunnable in the
> RunnableQueue. After fixing this there are no memory leaks reported by
> regard.
My mistake, forgot to run the NullURITest/NullSetSVGDocumentTest.
*resumes testing*
--
Cameron McCormack, http://mcc.id.au/
xmpp:heycam@jabber.org ▪ ICQ 26955922 ▪ MSN cam@mcc.id.au
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by Cameron McCormack <ca...@mcc.id.au>.
Cameron McCormack:
> The last time I investigated them (maybe a month or two ago?) I think
> there was a reference being held by the test object that was causing the
> canvas/document to be held. I’ll have another look tomorrow to make
> sure it’s not a real leak.
The only problem I found was that SVG 1.2 resource documents were being
held in memory because of the animation engine’s IdleRunnable in the
RunnableQueue. After fixing this there are no memory leaks reported by
regard.
Just have to wait on https://bugzilla.mozilla.org/show_bug.cgi?id=367627
to be applied and a release of Rhino to be made including the patch,
now.
--
Cameron McCormack, http://mcc.id.au/
xmpp:heycam@jabber.org ▪ ICQ 26955922 ▪ MSN cam@mcc.id.au
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by Cameron McCormack <ca...@mcc.id.au>.
Thomas DeWeese:
> I've applied the patches I could. I ran into problems with 41205 as
> the
> WMF files did not render the same as SVG as they did WMF. I'd like
> to give a Herve a day to look into this/respond but it isn't a big deal
> for me one
> way or the other.
Ok.
> I think I've fixed the 'Missing Resource Bundle' problem the correct
> way
> (LocalizableSupport can now walk the class tree looking for a
> ResourceBundle
> with the needed key), some care was taken to keep performance similar in
> similar
> situations.
Cool.
> I've updated the reference images that had 'trivial' differences on my
> machine.
>
> The only issue I have is that some of the memory leak tests are still
> failing.
> I haven't had much time to look into possible reasons for false
> positive's.
> Cameron and Dieter have either of you?
The last time I investigated them (maybe a month or two ago?) I think
there was a reference being held by the test object that was causing the
canvas/document to be held. I’ll have another look tomorrow to make
sure it’s not a real leak.
> In any case I think we can go ahead with the RC in the next day or two.
> I think it will be best to treat the RC as a real release, but I don't
> think we
> should advertise it outside of the Batik Mail-lists.
Ok.
> Lots of hard work went into this, cheers all around!!!
Indeed! =)
--
Cameron McCormack, http://mcc.id.au/
xmpp:heycam@jabber.org ▪ ICQ 26955922 ▪ MSN cam@mcc.id.au
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
On 28.01.2007 00:36:01 Cameron McCormack wrote:
> Cameron McCormack:
> > > I read through some messages before 1.6’s release, and noted that even
> > > a RC must go through the formal process of getting a vote from the PMC.
> > > That’d be the next step then?
>
> Jeremias Maerki:
> > As long as you call it RC, don't make it known beyond batik-dev and
> > don't distribute it through the standard mirrors, no. See:
> > http://www.apache.org/dev/release.html#release-typeso
> >
> > If you target a wider audience, then yes. In that case, build the
> > release files and put them on your ~/public_html/<something> (-->
> > people.apache.org/~<uid>/<something>) and then start a vote (on general,
> > cc batik-dev) referencing the files, ideally with MD5s. When the vote
> > passes the artifacts are pushed into the distribution space.
>
> Hmm, I guess I would like something in between these. I don’t really
> want to keep the RC in the distribution archive, since it’s really just
> a temporary thing. But I do want to have it tested by the wider SVG
> community. Any way this could happen? Or should I just accept that an
> RC is just like any other release? :)
Given how long RC versions popped up on the FOP users mailing list long
after final releases were available, you should see it as a normal
release which has to be approved by the PMC, even if you don't
distribute it through the mirrors. However, if you announce the release
to a wider community infrastructure may not be happy about the generated
traffic if it's not going through the mirrors.
Jeremias Maerki
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by Cameron McCormack <ca...@mcc.id.au>.
Cameron McCormack:
> > I read through some messages before 1.6’s release, and noted that even
> > a RC must go through the formal process of getting a vote from the PMC.
> > That’d be the next step then?
Jeremias Maerki:
> As long as you call it RC, don't make it known beyond batik-dev and
> don't distribute it through the standard mirrors, no. See:
> http://www.apache.org/dev/release.html#release-typeso
>
> If you target a wider audience, then yes. In that case, build the
> release files and put them on your ~/public_html/<something> (-->
> people.apache.org/~<uid>/<something>) and then start a vote (on general,
> cc batik-dev) referencing the files, ideally with MD5s. When the vote
> passes the artifacts are pushed into the distribution space.
Hmm, I guess I would like something in between these. I don’t really
want to keep the RC in the distribution archive, since it’s really just
a temporary thing. But I do want to have it tested by the wider SVG
community. Any way this could happen? Or should I just accept that an
RC is just like any other release? :)
--
Cameron McCormack, http://mcc.id.au/
xmpp:heycam@jabber.org ▪ ICQ 26955922 ▪ MSN cam@mcc.id.au
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
On 27.01.2007 09:15:00 Cameron McCormack wrote:
> Thomas DeWeese:
> > Here is my list, I'm applying them locally (any opinions
> > on 41216).
> >
> > 40681 - Patch already provided (thanks to Archie).
> > 41205 - Patch already provided (thanks to Herve).
>
> I didn’t review the patches, but if you’re happy with them that’s fine.
>
> > 41216 - Patch is available, (thanks to Trejkaz) I don't think
> > we have a CLA but the patch is basically just adding
> > all the other charsets.
>
> Yeah I’m a bit worried the patch is too large to accept without a CLA.
> Did you contact Trejkaz about it?
>
> > 41234 - We should try and make sure the resource files
> > for errors can be found (this has popped up in a few
> > places).
> > The simple fix may be to just replicating the
> > Messages.properties to the new directory. I actually
> > think our whole messaging system needs some work.
>
> I’m happy with that as a stop-gap solution. (I guess Jeremias could do
> that too for FOP’s related problem, before a proper solution is made.)
Yep, we just have to make sure we don't forget about it.
>
> So after these changes, I guess we’re done, and a release candidate can
> be made. I’ll collate the bugs in Bugzilla that have been closed since
> the 1.6 release so that they can be included in the README file in the
> distribution directory.
>
> I read through some messages before 1.6’s release, and noted that even
> a RC must go through the formal process of getting a vote from the PMC.
> That’d be the next step then?
As long as you call it RC, don't make it known beyond batik-dev and
don't distribute it through the standard mirrors, no. See:
http://www.apache.org/dev/release.html#release-typeso
If you target a wider audience, then yes. In that case, build the
release files and put them on your ~/public_html/<something> (-->
people.apache.org/~<uid>/<something>) and then start a vote (on general,
cc batik-dev) referencing the files, ideally with MD5s. When the vote
passes the artifacts are pushed into the distribution space.
Jeremias Maerki
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by Dieter von Holten <in...@dvholten.de>.
i'd propose to ship both.
----- Original Message -----
From: "Cameron McCormack" <ca...@mcc.id.au>
To: <ba...@xmlgraphics.apache.org>
Sent: Monday, January 29, 2007 5:52 AM
Subject: Re: Ready for release?
> Dieter von Holten:
> > what will the content of the release? One jar-file compiled for jdk
1.3 -
> > with an invitation 'roll your own for 1.4' ?? Or two jar-files: one for
jdk
> > 1.3, one for 1.4 ??
>
> Oh yes, I’d forgotten about that issue. FOP distribute 1.3- and
> 1.4-compiled distributions. That seems acceptable to me. You?
>
> --
> Cameron McCormack, http://mcc.id.au/
> xmpp:heycam@jabber.org ▪ ICQ 26955922 ▪ MSN cam@mcc.id.au
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
> For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by th...@kodak.com.
Hi All,
> Dieter von Holten:
> > what will the content of the release?
Cameron McCormack <ca...@mcc.id.au> wrote on 01/28/2007 11:52:03 PM:
> Oh yes, I?d forgotten about that issue. FOP distribute 1.3- and
> 1.4-compiled distributions. That seems acceptable to me. You?
This is fine, especially as I suspect this will be the last
"major" release supporting JDK 1.3 (too much stuff pushes towards
JDK 1.4+).
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by Cameron McCormack <ca...@mcc.id.au>.
Dieter von Holten:
> what will the content of the release? One jar-file compiled for jdk 1.3 -
> with an invitation 'roll your own for 1.4' ?? Or two jar-files: one for jdk
> 1.3, one for 1.4 ??
Oh yes, I’d forgotten about that issue. FOP distribute 1.3- and
1.4-compiled distributions. That seems acceptable to me. You?
--
Cameron McCormack, http://mcc.id.au/
xmpp:heycam@jabber.org ▪ ICQ 26955922 ▪ MSN cam@mcc.id.au
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by Dieter von Holten <in...@dvholten.de>.
hello,
what will the content of the release? One jar-file compiled for jdk 1.3 -
with an invitation 'roll your own for 1.4' ?? Or two jar-files: one for jdk
1.3, one for 1.4 ??
greetings
dieter
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by Cameron McCormack <ca...@mcc.id.au>.
Cameron McCormack:
> I’ll collate the bugs in Bugzilla that have been closed since
> the 1.6 release so that they can be included in the README file in the
> distribution directory.
I’ve committed a CHANGES file to the repository, so that this change log
file can be version controlled. This is the same as the README file in
the distribution directory, without the top paragraph that mentions that
the directory it’s in contains the current distribution files.
I went through the svn logs and the Bugzilla entries that were closed
since the 1.6 release and wrote up the change log. Please add entries
if I missed anything. The README file can be manually updated then with
the contents of the CHANGES file, when the release is made.
--
Cameron McCormack, http://mcc.id.au/
xmpp:heycam@jabber.org ▪ ICQ 26955922 ▪ MSN cam@mcc.id.au
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by Hervé Girod <he...@club-internet.fr>.
Thanks, but there's a good chance I was the one who created the bug in
the first place, so I felt my duty to clean up your own mess...
Hervé
thomas.deweese@kodak.com wrote:
> Hi Herve,
>
> Hervé Girod <he...@club-internet.fr> wrote on 01/29/2007 07:39:05
> PM:
>
>
>> Second version of the patch fix the problem.
>>
>
> Thanks, the patch is applied and checked into SVN,
> the problem has gone away!.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
> For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
>
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by th...@kodak.com.
Hi Herve,
Hervé Girod <he...@club-internet.fr> wrote on 01/29/2007 07:39:05
PM:
> Second version of the patch fix the problem.
Thanks, the patch is applied and checked into SVN,
the problem has gone away!.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by Hervé Girod <he...@club-internet.fr>.
Hi,
Second version of the patch fix the problem. As said in bugzilla, it was
due to a typo in some code retrieving the clipping coordinates for
texts, in theWMFPainter class. This bug was introduced before this patch
(good chance it was my fault), but I don't know when...
Hervé
thomas.deweese@kodak.com wrote:
> Hi all,
>
> I've applied the patches I could. I ran into problems with 41205 as
> the
> WMF files did not render the same as SVG as they did WMF. I'd like
> to give a Herve a day to look into this/respond but it isn't a big deal
> for me one
> way or the other.
>
> I think I've fixed the 'Missing Resource Bundle' problem the correct
> way
> (LocalizableSupport can now walk the class tree looking for a
> ResourceBundle
> with the needed key), some care was taken to keep performance similar in
> similar
> situations.
>
> I've updated the reference images that had 'trivial' differences on my
> machine.
>
> The only issue I have is that some of the memory leak tests are still
> failing.
> I haven't had much time to look into possible reasons for false
> positive's.
> Cameron and Dieter have either of you?
>
> In any case I think we can go ahead with the RC in the next day or two.
> I think it will be best to treat the RC as a real release, but I don't
> think we
> should advertise it outside of the Batik Mail-lists.
>
> Lots of hard work went into this, cheers all around!!!
>
> Cameron McCormack <ca...@mcc.id.au> wrote on 01/27/2007 03:15:00 AM:
>
>
>> Thomas DeWeese:
>>
>>> Here is my list, I'm applying them locally (any opinions
>>> on 41216).
>>>
>>> 40681 - Patch already provided (thanks to Archie).
>>> 41205 - Patch already provided (thanks to Herve).
>>>
>> I didn?t review the patches, but if you?re happy with them that?s fine.
>>
>>
>>> 41216 - Patch is available, (thanks to Trejkaz) I don't think
>>> we have a CLA but the patch is basically just adding
>>> all the other charsets.
>>>
>> Yeah I?m a bit worried the patch is too large to accept without a CLA.
>> Did you contact Trejkaz about it?
>>
>>
>>> 41234 - We should try and make sure the resource files
>>> for errors can be found (this has popped up in a few
>>>
>
>
>>> places).
>>> The simple fix may be to just replicating the
>>> Messages.properties to the new directory. I actually
>>> think our whole messaging system needs some work.
>>>
>> I?m happy with that as a stop-gap solution. (I guess Jeremias could do
>> that too for FOP?s related problem, before a proper solution is made.)
>>
>>
>> So after these changes, I guess we?re done, and a release candidate can
>> be made. I?ll collate the bugs in Bugzilla that have been closed since
>> the 1.6 release so that they can be included in the README file in the
>> distribution directory.
>>
>> I read through some messages before 1.6?s release, and noted that even
>> a RC must go through the formal process of getting a vote from the PMC.
>> That?d be the next step then?
>>
>> --
>> Cameron McCormack, http://mcc.id.au/
>> xmpp:heycam@jabber.org ? ICQ 26955922 ? MSN cam@mcc.id.au
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
>> For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
> For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
>
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by Dieter von Holten <in...@dvholten.de>.
>> The only issue I have is that some of the memory leak tests are still
>> failing.
>> I haven't had much time to look into possible reasons for false
>> positive's.
>> Cameron and Dieter have either of you?
>
> The last time I investigated them (maybe a month or two ago?) I think
> there was a reference being held by the test object that was causing the
> canvas/document to be held. I'll have another look tomorrow to make
> sure it's not a real leak.
i looked at the memory leak test long ago after getting those messages.
i often have one or two objects left over, sometimes none. it seems more a
problem of the test than of what is tested.
final thing i want to do for RC is to do some benchmark to see much speed we
gained.
i want to use the spain-map, because i think that is fairly complicated and
close to real-world use.
Any other proposals ?
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by th...@kodak.com.
Hi all,
I've applied the patches I could. I ran into problems with 41205 as
the
WMF files did not render the same as SVG as they did WMF. I'd like
to give a Herve a day to look into this/respond but it isn't a big deal
for me one
way or the other.
I think I've fixed the 'Missing Resource Bundle' problem the correct
way
(LocalizableSupport can now walk the class tree looking for a
ResourceBundle
with the needed key), some care was taken to keep performance similar in
similar
situations.
I've updated the reference images that had 'trivial' differences on my
machine.
The only issue I have is that some of the memory leak tests are still
failing.
I haven't had much time to look into possible reasons for false
positive's.
Cameron and Dieter have either of you?
In any case I think we can go ahead with the RC in the next day or two.
I think it will be best to treat the RC as a real release, but I don't
think we
should advertise it outside of the Batik Mail-lists.
Lots of hard work went into this, cheers all around!!!
Cameron McCormack <ca...@mcc.id.au> wrote on 01/27/2007 03:15:00 AM:
> Thomas DeWeese:
> > Here is my list, I'm applying them locally (any opinions
> > on 41216).
> >
> > 40681 - Patch already provided (thanks to Archie).
> > 41205 - Patch already provided (thanks to Herve).
>
> I didn?t review the patches, but if you?re happy with them that?s fine.
>
> > 41216 - Patch is available, (thanks to Trejkaz) I don't think
> > we have a CLA but the patch is basically just adding
> > all the other charsets.
>
> Yeah I?m a bit worried the patch is too large to accept without a CLA.
> Did you contact Trejkaz about it?
>
> > 41234 - We should try and make sure the resource files
> > for errors can be found (this has popped up in a few
> > places).
> > The simple fix may be to just replicating the
> > Messages.properties to the new directory. I actually
> > think our whole messaging system needs some work.
>
> I?m happy with that as a stop-gap solution. (I guess Jeremias could do
> that too for FOP?s related problem, before a proper solution is made.)
>
>
> So after these changes, I guess we?re done, and a release candidate can
> be made. I?ll collate the bugs in Bugzilla that have been closed since
> the 1.6 release so that they can be included in the README file in the
> distribution directory.
>
> I read through some messages before 1.6?s release, and noted that even
> a RC must go through the formal process of getting a vote from the PMC.
> That?d be the next step then?
>
> --
> Cameron McCormack, http://mcc.id.au/
> xmpp:heycam@jabber.org ? ICQ 26955922 ? MSN cam@mcc.id.au
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
> For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by Cameron McCormack <ca...@mcc.id.au>.
Thomas DeWeese:
> Here is my list, I'm applying them locally (any opinions
> on 41216).
>
> 40681 - Patch already provided (thanks to Archie).
> 41205 - Patch already provided (thanks to Herve).
I didn’t review the patches, but if you’re happy with them that’s fine.
> 41216 - Patch is available, (thanks to Trejkaz) I don't think
> we have a CLA but the patch is basically just adding
> all the other charsets.
Yeah I’m a bit worried the patch is too large to accept without a CLA.
Did you contact Trejkaz about it?
> 41234 - We should try and make sure the resource files
> for errors can be found (this has popped up in a few
> places).
> The simple fix may be to just replicating the
> Messages.properties to the new directory. I actually
> think our whole messaging system needs some work.
I’m happy with that as a stop-gap solution. (I guess Jeremias could do
that too for FOP’s related problem, before a proper solution is made.)
So after these changes, I guess we’re done, and a release candidate can
be made. I’ll collate the bugs in Bugzilla that have been closed since
the 1.6 release so that they can be included in the README file in the
distribution directory.
I read through some messages before 1.6’s release, and noted that even
a RC must go through the formal process of getting a vote from the PMC.
That’d be the next step then?
--
Cameron McCormack, http://mcc.id.au/
xmpp:heycam@jabber.org ▪ ICQ 26955922 ▪ MSN cam@mcc.id.au
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by Hervé Girod <he...@club-internet.fr>.
Hello,
Any chance you also want to apply this one : 35515 ? (Problem with
converting WMF files to SVG Documents). This problem is not specific to
WMF Files transcoding, and will happen any time SVGGraphics2D is used. I
already provided a patch, and I can / will add soon (today or tomorrow)
some code to test it.
But I agree that this is not a big problem...
Herve
thomas.deweese@kodak.com wrote:
> Hi All,
>
> thomas.deweese@kodak.com wrote on 01/22/2007 07:35:15 PM:
>
>
>> There are a few I'd like to try and tackle, I'm working on a list
>> (most are ones with patches already in bugzilla).
>>
>
> Here is my list, I'm applying them locally (any opinions
> on 41216).
>
> 40681 - Patch already provided (thanks to Archie).
> 41205 - Patch already provided (thanks to Herve).
> 41216 - Patch is available, (thanks to Trejkaz) I don't think
> we have a CLA but the patch is basically just adding
> all the other charsets.
> 41234 - We should try and make sure the resource files
> for errors can be found (this has popped up in a few
> places).
> The simple fix may be to just replicating the
> Messages.properties to the new directory. I actually
> think our whole messaging system needs some work.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
> For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
>
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by th...@kodak.com.
Hi All,
thomas.deweese@kodak.com wrote on 01/22/2007 07:35:15 PM:
> There are a few I'd like to try and tackle, I'm working on a list
> (most are ones with patches already in bugzilla).
Here is my list, I'm applying them locally (any opinions
on 41216).
40681 - Patch already provided (thanks to Archie).
41205 - Patch already provided (thanks to Herve).
41216 - Patch is available, (thanks to Trejkaz) I don't think
we have a CLA but the patch is basically just adding
all the other charsets.
41234 - We should try and make sure the resource files
for errors can be found (this has popped up in a few
places).
The simple fix may be to just replicating the
Messages.properties to the new directory. I actually
think our whole messaging system needs some work.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Ready for release?
Posted by th...@kodak.com.
Hi Cameron,
Thanks for all the hard work on this!
Cameron McCormack <ca...@mcc.id.au> wrote on 01/22/2007 03:40:17 AM:
> Thomas and Dieter, could you run regard on your systems to see that
> there?s nothing that?s been overlooked?
Certainly.
> I will do so also. I don?t think there are any more low-hanging
> fruits in Bugzilla, but have a skim through them in case I missed
> something.
There are a few I'd like to try and tackle, I'm working on a list
(most are ones with patches already in bugzilla).
> Given the number of changes since the last release, would it be wise to
> make a release candidate that people can test, before the proper 1.7
> release? If so, how long for?
My experience is that not a lot of people test with release
candidates, so something fairly short like 1-2 weeks should be
fine (the people who do test will tend to do so quickly), if
people start finding important problems then the final release
could be delayed appropriately.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org